Skip to content

chore(~): use ESlint (closes #117) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2015
Merged

chore(~): use ESlint (closes #117) #126

merged 3 commits into from
Apr 21, 2015

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Mar 12, 2015

But not working yet

Blockers:

@akibot
Copy link
Contributor

akibot commented Mar 12, 2015

Hello! Thank you for sending us patches!

I am an automated bot to lint pull requests to detect potential errors and check for consistent coding style, and I found some problems with your code submission in the commit 5d02f96:

  • tasks/lint.js
    • line 4, col 8: 'jshint' is defined but never used. (W098)
    • line 5, col 8: 'jscs' is defined but never used. (W098)

Please fix these problems, rebase your commits, then leave a comment here so that a human can further review your patch.

As an additional step to prevent future lint errors, please run npm lint before committing. A Git pre-commit hook is available.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.03% when pulling 4c06fb4 on eslint into 5a8be21 on master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 611281f on eslint into * on master*.

dtinth added a commit that referenced this pull request Apr 21, 2015
chore(~): use ESlint (closes #117)
@dtinth dtinth merged commit 04275dd into master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants