Skip to content

Automatically review pull requests #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 30, 2014
Merged

Automatically review pull requests #51

merged 4 commits into from
Dec 30, 2014

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Dec 30, 2014

Closes #10

@dtinth dtinth force-pushed the auto-code-review#10 branch from 8fda156 to 5216951 Compare December 30, 2014 08:47
@akibot
Copy link
Contributor

akibot commented Dec 30, 2014

Hello! Thank you for sending us patches!

I am an automated bot to lint pull requests to detect potential errors and check for consistent coding style, and I found some problems with your code submission in the commit b3d1259:

  • tasks/code-review.js
    • line 94, col 10: 'badFunction' is defined but never used. (W098)
    • line 95, col 7: Expected '===' and instead saw '=='. (W116)
    • line 95, col 8: Expected an assignment or function call and instead saw an expression. (W030)
    • line 95, col 9: semicolons are disallowed at the end of a line. (disallowSemicolons)

Please fix these problems, rebase your commits, then leave a comment here so that a human can further review your patch.

As an additional step to prevent future lint errors, please run npm lint before committing. A Git pre-commit hook is available.

dtinth added a commit that referenced this pull request Dec 30, 2014
Automatically review pull requests
@dtinth dtinth merged commit 725df0a into master Dec 30, 2014
@dtinth dtinth deleted the auto-code-review#10 branch January 17, 2015 05:44
rajr5 pushed a commit to rajr5/bemuse that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically review pull-requests
2 participants