up load fn to async in src/auto-synchro/music.js
#646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
=======================================
Coverage 80.85% 80.85%
=======================================
Files 156 156
Lines 4764 4764
Branches 184 184
=======================================
Hits 3852 3852
Misses 863 863
Partials 49 49Continue to review full report at Codecov.
|
dtinth
approved these changes
Oct 3, 2019
dtinth
added
c:ready
category:Internals
to merge
|
Closing as I just realized that this PR has already been cherry picked — d382b7a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried my best to understand 'co', I hope this is good :)
fixes #626
Changelog
Migrate part of the code from
cotoasync functions