Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes from @fiskhandlarn #33

Closed
wants to merge 7 commits into from
Closed

Conversation

@ben-xo
Copy link
Owner

ben-xo commented Jan 10, 2020

No description provided.

@ben-xo

This comment has been minimized.

Copy link

ben-xo commented on 5b5e2dd Dec 31, 2019

This is a cool idea - what software tags with "year" that's a fully formed date?

I may integrate this change into the main line

This comment has been minimized.

Copy link
Author

fiskhandlarn replied Jan 9, 2020

I used Mp3tag. Although it's not supported by the id3 standard (I think) I'm using it to set the dates for our podcast.

@ben-xo

This comment has been minimized.

Copy link

ben-xo commented on 1ddca42 Dec 31, 2019

I've integrated this change into the main line. Thanks for the tip!

This comment has been minimized.

Copy link
Author

fiskhandlarn replied Jan 9, 2020

Of course, glad to be of help. :)

@ben-xo

This comment has been minimized.

Copy link

ben-xo commented on 9b8673b Dec 31, 2019

Any reason in specific you prefer commas to pipes here? I chose pipes because they're unlikely to be in the Apple category names. (Although, that's probably also true of commas).

This comment has been minimized.

Copy link
Author

fiskhandlarn replied Jan 9, 2020

It's explained in the commit message:

Issue: pipe (|) is interpreted by PHP as bitwise or

This comment has been minimized.

Copy link

ben-xo replied Jan 10, 2020

@fiskhandlarn you know, I saw that commit message, and completely misunderstood your intention. It simply hadn't occurred to me that PHP's ini-parsing interprets mathematical and bitwise expressions - even though it obviously does interpret those when parsing php.ini. I had thought that you made the change for cosmetic reasons.

Thanks for your patch!

This comment has been minimized.

Copy link
Author

fiskhandlarn replied Jan 12, 2020

I didn't understand what was happening at first, but it makes sense (so that you can use bitwise operators for PHP flags in in files (error_reporting and so on)).

@ben-xo

This comment has been minimized.

Copy link
Owner Author

ben-xo commented Jan 10, 2020

I'll integrate the changes manually as this would lead to a lot of whitespace changes.

@ben-xo ben-xo closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.