Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Jekyll 4.0.0 #66

Closed
pavelkomarov opened this issue Jan 13, 2020 · 4 comments
Closed

Not working with Jekyll 4.0.0 #66

pavelkomarov opened this issue Jan 13, 2020 · 4 comments

Comments

@pavelkomarov
Copy link

pavelkomarov commented Jan 13, 2020

I've added jekyll-remote-theme as a plugin in my site's _config.yml. I've set remote_theme: pavelkomarov/hyde. If I push up to github pages, it works fine. If I jekyll serve --verbose --trace locally, the theme downloads, unzips, and then fails with this error message about a missing method.

undefined method `configure_sass'; for #<Jekyll::RemoteTheme::Theme:0x...> NoMethodError

There is another thread about this (#60), and you answered it was a work in progress, and then it looks from the discussion like it was solved. But I'm on jekyll-remote-theme-0.4.1, and it's not solved. Is this actually a Jekyll issue? Whatever the case it's making development with a remote theme really inconvenient. I don't want to have to completely deploy to see what my changes look like.

@pavelkomarov
Copy link
Author

pavelkomarov commented Jan 13, 2020

I managed to follow the breadcrumbs to jekyll/minima#422 (comment), and then find further evidence github-pages isn't get on Jekyll 4.0, and then discover I have both Jekyll 3.8.5 and 4.0.0 on my machine, and then update the symlink so which jekyll points me at the older one, and now I'm not getting this error anymore.

I can develop locally again! Caching of the remote theme so I didn't have to download it anew each time if no updates (quickly calculable by whether a hash matches) should still be implemented to make this seamless (#22), but it's still better than having to deploy constantly.

Why does 4.0.0 break you?

@pavelkomarov
Copy link
Author

pavelkomarov commented Jan 17, 2020

Just discovered that cloning then calling script/bootstrap then calling script/cibuild results in five test failures me, because I don't have JEKYLL_VERSION set in my environment, so bundler just goes and grabs 4.0.0. If I purposefully regress jekyll to 3.8.5 by manually editing the Gemfile, then the tests all pass.

image

@pavelkomarov pavelkomarov changed the title undefined method `configure_sass'; for #<Jekyll::RemoteTheme::Theme:0x...> NoMethodError Not working with Jekyll 4.0.0 Jan 17, 2020
@hszhakka
Copy link

This problem can be solved by following these steps: #60 (comment).

@pavelkomarov
Copy link
Author

Awesome. Hope that gets released to rubygems soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants