New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing feedback #8

Closed
daviddarnes opened this Issue Oct 22, 2017 · 2 comments

Comments

2 participants
@daviddarnes

daviddarnes commented Oct 22, 2017

Hi 馃憢, I created the theme Alembic. I was copied in on a thread from @DirtyF to test out this plugin. Here's what I found:

Installation

  1. Created a new site using jekyll new
  2. Followed the installation steps of this plugin (added the plugin to the jekyll_plugins group in the Gemfile)
  3. Tried serving the site with bundle exec jekyll serve, but due to my theme using jekyll-seo-tag the site failed to build. I've hit problems before with the specific {% seo %} so maybe this is more of an issue with that gem? It would be nice if it caused a warning instead?
  4. Added the jekyll-seo-tag plugin and tried again and it worked as expected 馃帀

Parting notes

  • Works exactly as expected 馃憤
  • Issue with theme dependancies, but as seen here there are problems with catering for this
  • Should plugins error more gracefully? Open question 馃挰
  • The resulting site is quite blank, maybe my theme isn't working hard enough 馃槼

Discussion thread on the Jekyll forums if people want to chat further https://talk.jekyllrb.com/t/plugin-jekyll-remote-theme/1089/5

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Oct 23, 2017

Owner

@daviddarnes thanks for this great feedback. As an initial release, plugins are a bit of a rough edge still. Although #4 is just a placeholder for the moment, I'd love to see a better user experience around plugins. At the very least, we could potentially warn users if the theme requires a plugin that's not in the config, and ideally, we'd be able to require it if it's part of the whitelist (or always require it if not in safe mode).

Owner

benbalter commented Oct 23, 2017

@daviddarnes thanks for this great feedback. As an initial release, plugins are a bit of a rough edge still. Although #4 is just a placeholder for the moment, I'd love to see a better user experience around plugins. At the very least, we could potentially warn users if the theme requires a plugin that's not in the config, and ideally, we'd be able to require it if it's part of the whitelist (or always require it if not in safe mode).

@daviddarnes

This comment has been minimized.

Show comment
Hide comment
@daviddarnes

daviddarnes Oct 24, 2017

@benbalter you're very welcome! Totally understand with plugins, I appreciate that you need to take a somewhat delicate approach to this as it could potentially affect a lot of people. If you require any more testing just let us know, I'll probably be dropping by this repo every so often anyway. I'm keen to make my theme versatile for different platforms.

daviddarnes commented Oct 24, 2017

@benbalter you're very welcome! Totally understand with plugins, I appreciate that you need to take a somewhat delicate approach to this as it could potentially affect a lot of people. If you require any more testing just let us know, I'll probably be dropping by this repo every so often anyway. I'm keen to make my theme versatile for different platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment