Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown converter places all links at the end of the document which can break excepts #66

Closed
sumdog opened this issue Oct 4, 2015 · 2 comments

Comments

@sumdog
Copy link

sumdog commented Oct 4, 2015

I noticed the export plugin likes to place all the links at the bottom and then reference them using the markdown bracket syntax:

[Some link][1] and some text 
....rest of the blog post....
[1]: http://example.org

I can appreciate it trying t consolidate links, but this totally breaks using {{ post.excerpt }} since the links aren't available in the except. I'm going to look into this, but I thought I'd post an issue here first.

I think the solution needs to be an option to inline the links instead of separating them.

@sumdog
Copy link
Author

sumdog commented Oct 4, 2015

Just an update, the markdown converter supports having them inline by setting const LINK_IN_PARAGRAPH = 2; as a constructor argument. Quick and dirty you can hack this

$converter = new Markdownify\ConverterExtra(2);

...into the plugin. If I get time I'll try to make it a setting in the plugin and do a pull request.

@benbalter
Copy link
Owner

Fixed via 88fe49b. Thanks for the suggestion @sumdog!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants