New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to RewriteVersion because it will install on newer Perls #77

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@genio

genio commented Oct 1, 2016

Hi!

I received your module as part of this month's CPAN PR-Challenge. Making use of RewriteVersion gets rid of the following problem when trying to build on newer Perls with Dist::Zilla:

$ cpanm Dist::Zilla::Plugin::VersionFromModule
--> Working on Dist::Zilla::Plugin::VersionFromModule
Fetching http://www.cpan.org/authors/id/C/CJ/CJM/Dist-Zilla-Plugins-CJM-4.27.tar.gz ... OK
Configuring Dist-Zilla-Plugins-CJM-4.27 ... OK
Building and testing Dist-Zilla-Plugins-CJM-4.27 ... FAIL
! Installing Dist::Zilla::Plugin::VersionFromModule failed. See /Users/cwhitener/.cpanm/work/1473390305.53210/build.log for details. Retry with --force to force install it.

Thanks,
Chase

@benbernard

This comment has been minimized.

Show comment
Hide comment
@benbernard

benbernard Oct 1, 2016

Owner

Thanks a bunch for the contribution. Do you know if this can be tested on travis, if so I'd like to make sure this is a part of that. Also @tsibley knows a bunch more about our dist build process at this point, perhaps he would like to chime in?

Owner

benbernard commented Oct 1, 2016

Thanks a bunch for the contribution. Do you know if this can be tested on travis, if so I'd like to make sure this is a part of that. Also @tsibley knows a bunch more about our dist build process at this point, perhaps he would like to chime in?

@tsibley

This comment has been minimized.

Show comment
Hide comment
@tsibley

tsibley Oct 1, 2016

Collaborator

Hmm, it seems like the underlying problem is with the VersionFromModule plugin: https://rt.cpan.org/Public/Bug/Display.html?id=116902

There are two outstanding PRs to fix VersionFromModule which were recently (~month or two) filed: https://github.com/madsen/dist-zilla-plugins-cjm/pulls

Collaborator

tsibley commented Oct 1, 2016

Hmm, it seems like the underlying problem is with the VersionFromModule plugin: https://rt.cpan.org/Public/Bug/Display.html?id=116902

There are two outstanding PRs to fix VersionFromModule which were recently (~month or two) filed: https://github.com/madsen/dist-zilla-plugins-cjm/pulls

@tsibley

This comment has been minimized.

Show comment
Hide comment
@tsibley

tsibley Oct 1, 2016

Collaborator

@genio Thanks for looking into this! Did you have a chance to test the dist build/release cycle with your changes? We should verify that RewriteVersion + ReversionOnRelease play nice together since RewriteVersion both provides and updates versions where as VersionFromModule only provides (letting ReversionOnRelease do the updates).

Collaborator

tsibley commented Oct 1, 2016

@genio Thanks for looking into this! Did you have a chance to test the dist build/release cycle with your changes? We should verify that RewriteVersion + ReversionOnRelease play nice together since RewriteVersion both provides and updates versions where as VersionFromModule only provides (letting ReversionOnRelease do the updates).

@tsibley tsibley added the stalled label Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment