New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `vault read` output formatting, add back links and various code quality improvements #1

Merged
merged 4 commits into from Oct 11, 2017

Conversation

Projects
None yet
2 participants
@dvejmz
Copy link
Contributor

dvejmz commented Oct 7, 2017

I've added two new features to this:

  • vault read output format is now preserved.
  • Added back buttons to every page to make navigation easier

I've also made a number of changes to the code:

  • Refactors to split up logic in index.js, extracted Vault logic into a separate module
  • Added an .editorconfig file and a linter for it with the possibility to both check (lint-check) and fix (lint-fix) our code (won't affect libs). I've decided to use 2 spaces, as this was the original convention.
  • Added .tern-project file to enable Node autocompletion for those like me that use the Tern JS completion engine
@benbrunton
Copy link
Owner

benbrunton left a comment

Thanks David! Great update, much appreciated! 💯

@benbrunton benbrunton merged commit f0880d4 into benbrunton:master Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment