Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigMaps and Secrets #16

Merged
merged 3 commits into from Mar 11, 2020
Merged

ConfigMaps and Secrets #16

merged 3 commits into from Mar 11, 2020

Conversation

@REBELinBLUE
Copy link
Contributor

REBELinBLUE commented Mar 1, 2020

For #15

I didn't bother waiting for your response as I realised how simple it was really if you don't want to merge it then fair enough :)

Haven't done ConfigMaps and Secrets referenced by pod.spec.containers.env, I can add them if you want

@REBELinBLUE REBELinBLUE force-pushed the REBELinBLUE:configmaps branch from 392c15c to 83fd4bd Mar 1, 2020
@benc-uk benc-uk self-assigned this Mar 11, 2020
@benc-uk

This comment has been minimized.

Copy link
Owner

benc-uk commented Mar 11, 2020

This looks good, more than happy to merge this

@benc-uk benc-uk merged commit 0bf6710 into benc-uk:master Mar 11, 2020
1 check failed
1 check failed
buildJob buildJob
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.