Skip to content

Commit

Permalink
Allows for use of non-https domains under El Capitan
Browse files Browse the repository at this point in the history
... when --ignore-ssl-check is enabled

Fixes paulhammond#90
  • Loading branch information
bendalton committed Oct 13, 2015
1 parent c0e91de commit 9a96ac8
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions webkit2png
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,10 @@ Examples:
# Hide the dock icon (needs to run before NSApplication.sharedApplication)
AppKit.NSBundle.mainBundle().infoDictionary()['LSBackgroundOnly'] = '1'

# Handles ATS HTTPS requirement introduced in El Cap
if options.ignore_ssl_check:
AppKit.NSBundle.mainBundle().infoDictionary()['NSAppTransportSecurity'] = dict(NSAllowsArbitraryLoads = True)

app = AppKit.NSApplication.sharedApplication()

# create an app delegate
Expand Down

7 comments on commit 9a96ac8

@alper
Copy link

@alper alper commented on 9a96ac8 Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out but I can't seem to get it to work.

@mysticaltech
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alper you gotta use the --ignore-ssl-check for this fix to work, if you found another way without using this switch please let me know.. thanks

@RasmusMalver
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also works on the Homebrewed version on mac. The file to edit is /usr/local/Cellar/webkit2png/0.7/bin/webkit2png, and it can be done in any text editor.

@datafunk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for brew
The manual fix works though, so thanks heaps!

@Avengio
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the workaround.

@ITRecords38
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

after have add this line a little problem.

File "/usr/local/bin/webkit2png", line 423
if options.ignore_ssl_check:
^
IndentationError: unexpected indent

Thanks for help

@helloalvin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handles ATS HTTPS requirement introduced in El Cap

#if options.ignore_ssl_check:

AppKit.NSBundle.mainBundle().infoDictionary()['NSAppTransportSecurity'] = dict(NSAllowsArbitraryLoads = True)

I tried like this,and it works,tks!

Please sign in to comment.