Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model.fit to take a user_items sparse matrix #484

Merged
merged 1 commit into from Oct 16, 2021

Conversation

benfred
Copy link
Owner

@benfred benfred commented Oct 16, 2021

Previously, model.fit took an item_users sparse matrix, while model.recommend took a user_items
sparse matrix. This was a source of confusion, so change the model.fit method to be consistent
with model.recommend

 Previously, model.fit took an item_users sparse matrix, while model.recommend took a user_items
 sparse matrix.  This was a source of confusion, so change the model.fit method to be consistent
 with model.recommend
@benfred benfred mentioned this pull request Oct 16, 2021
6 tasks
@benfred benfred merged commit ffb490d into api_refactor Oct 16, 2021
@benfred benfred deleted the model_fit_user_items branch October 16, 2021 17:05
@benfred benfred linked an issue Oct 16, 2021 that may be closed by this pull request
6 tasks
@benfred benfred removed a link to an issue Nov 26, 2021
6 tasks
benfred added a commit that referenced this pull request Dec 31, 2021
Previously, model.fit took an item_users sparse matrix, while model.recommend took a user_items
 sparse matrix.  This was a source of confusion, so change the model.fit method to be consistent
 with model.recommend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant