Browse files

build generic py2.py3 wheels on windows.

Building a python2 wheel seems to fail on windows:
Instead of building a platform specific version, build a wheel that should
work on both python2/3 on windows.
  • Loading branch information...
benfred committed Sep 15, 2018
1 parent 97f4581 commit 6c2706867f9c13a2e5f9f3acc6c9e47f890094e7
Showing with 12 additions and 4 deletions.
  1. +1 −1 appveyor.yml
  2. +11 −3
@@ -5,7 +5,7 @@ environment:
# Nightly 64-bit MSVC
- channel: stable
target: x86_64-pc-windows-msvc
CIBW_SKIP: "*win32* cp33-* cp34-*"
CIBW_SKIP: "*win32* cp27-* cp33-* cp34-* cp35-*"
CIBW_BEFORE_BUILD: pip install setuptools-rust
# from:
@@ -15,9 +15,17 @@ def finalize_options(self):
# Mark us as not a pure python package (we have platform specific rust code)
self.root_is_pure = False
# note: in theory we could also set up manylinx/py2.py3 tags here by overriding get_tags
# but that seems to break installing the py-spy binary on osx so instead we're
# renaming in ci/
def get_tag(self):
# this set's us up to build generic wheels.
# note: we're only doing this for windows right now (causes packaging issues
# with osx)
if not sys.platform.startswith("win"):
return _bdist_wheel.get_tag(self)
python, abi, plat = _bdist_wheel.get_tag(self)
python, abi = 'py2.py3', 'none'
return python, abi, plat
except ImportError:
bdist_wheel = None

0 comments on commit 6c27068

Please sign in to comment.