From e2e8a829e18935af7d1f82c5d9e6bf726a18552f Mon Sep 17 00:00:00 2001 From: Ben Higham Date: Wed, 1 Apr 2026 15:11:41 +1100 Subject: [PATCH] chore: remove custom code-review command in favor of pr-review-toolkit plugin The custom `.claude/commands/code-review.md` is redundant now that the `pr-review-toolkit` plugin provides `/pr-review-toolkit:review-pr` with 6 specialized agents covering all the same areas plus dedicated analysis for test coverage, error handling, type design, and code simplification. Closes #35 --- .claude/commands/code-review.md | 20 -------------------- .claude/skills/update-command-file/SKILL.md | 2 +- AGENTS.md | 1 - README.md | 1 - 4 files changed, 1 insertion(+), 23 deletions(-) delete mode 100644 .claude/commands/code-review.md diff --git a/.claude/commands/code-review.md b/.claude/commands/code-review.md deleted file mode 100644 index 0ee7e16..0000000 --- a/.claude/commands/code-review.md +++ /dev/null @@ -1,20 +0,0 @@ -Review the current PR for code quality, security, and convention adherence. - -Read CLAUDE.md for project conventions. - -## Context - -- !`gh pr view --json title,body,baseRefName,headRefName,additions,deletions` -- !`gh pr diff` - -## Review Checklist - -- Correctness and edge cases -- Type safety (no unnecessary `any`, non-null assertions justified) -- Security implications (injection, secrets, auth) -- Convention adherence per CLAUDE.md -- Test coverage for changed code paths -- Performance considerations - -Post specific findings as inline comments. Post a summary comment covering overall -assessment, key changes, and any concerns. diff --git a/.claude/skills/update-command-file/SKILL.md b/.claude/skills/update-command-file/SKILL.md index 9bfc3f4..e6dfc73 100644 --- a/.claude/skills/update-command-file/SKILL.md +++ b/.claude/skills/update-command-file/SKILL.md @@ -20,7 +20,7 @@ enough to produce consistent, high-quality results. Read 2-3 existing command files in `.claude/commands/` to absorb the conventions. Good representatives that cover different patterns: -- `code-review.md` — standard PR review (context extraction → checklist → inline comments) +- `security-review.md` — focused PR review (context extraction → checklist → inline comments) - `quality-audit.md` — complex multi-step audit (multiple categories → branch → atomic commits → PR) - `dependency-audit.md` — tool detection, multi-factor assessment, conditional output diff --git a/AGENTS.md b/AGENTS.md index 1e3dce5..af7a9a9 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -26,7 +26,6 @@ Centralized defaults and automation for all `benhigham` GitHub repositories: FUNDING.yml .claude/ commands/ # Reference command files — copy to per-repo as needed - code-review.md # PR code review renovate-review.md # Renovate dependency PR review test-gen.md # Generate missing tests for PR changes security-review.md # Security-focused PR review diff --git a/README.md b/README.md index 97b3825..d1b7e68 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,6 @@ invoke these commands on the appropriate event. | Command | Purpose | Trigger | | ------------------ | ---------------------------------------- | ------------------------ | -| `code-review` | PR code review with inline comments | PR open/reopen | | `renovate-review` | Review Renovate dependency PRs | PR open (renovate actor) | | `test-gen` | Generate missing tests for changed files | PR open | | `security-review` | Security-focused PR review | PR open |