{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":622330972,"defaultBranch":"master","name":"edk2","ownerLogin":"benjamindoron","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-01T19:42:33.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/9547650?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1702325356.0","currentOid":""},"activityList":{"items":[{"before":"3c399c29335d9dc8f65e6cd566c8771e4541fd6c","after":"4d2738481ef5d218850eab67ce5854d9c306cde2","ref":"refs/heads/dev/uefipayload","pushedAt":"2024-02-16T18:29:44.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"MdeModulePkg: Standalone MM core can use RSC infrastructure\n\nCc: Liming Gao \nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"MdeModulePkg: Standalone MM core can use RSC infrastructure"}},{"before":"a29dd908ab576a07d4ee635ad51416cec2577d74","after":"3c399c29335d9dc8f65e6cd566c8771e4541fd6c","ref":"refs/heads/dev/uefipayload","pushedAt":"2024-02-16T18:19:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset eight](https://review.coreboot.org/c/coreboot/+/74121/8) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"395c0736e9d5b8ec33d0bb8f1c298795e0886cb6","after":"992cc42739abdc8843d3e8d15bdd842814ea46b9","ref":"refs/heads/dev/minplatform","pushedAt":"2024-02-16T17:59:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"[WIP] MdeModulePkg/DxeCorePerformanceLib: Stash a local debug print\n\nIt seems MinPlatform builds are out-of-memory for performance\ninformation. Attempt to find out why later.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"[WIP] MdeModulePkg/DxeCorePerformanceLib: Stash a local debug print"}},{"before":"291e175671a1a624d789d588c754c1917233c3f7","after":"120971f77d15e77a27d8442cf51e7d5f18bcce95","ref":"refs/heads/dev/unified","pushedAt":"2024-02-16T17:57:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"[WIP] MdeModulePkg: Add new SerialPortLibMem\n\nSerialPortLibMem is an implementation of a SerialPortLib designed for\nobtaining debug messages in commercial systems or where debug\nfacilities might otherwise be restricted. It writes to a memory buffer\nand writes the address and offsets to variables at ExitBootServices()\nfor the user's convenience.\n\nThe PEI instance initially creates a small buffer, due to temporary\nmemory size restrictions, but may create and move to a larger buffer at\nPeiMemoryDiscovered. The DXE instance will copy the HOB to its own\nallocation to eventually provide to the user.\n\nThe SMM instance validates and uses the DXE instance's buffer. Further\nconsideration is required for the security of this phase.\n\nCc: Jian J Wang \nCc: Liming Gao \nCc: Nate DeSimone \nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"[WIP] MdeModulePkg: Add new SerialPortLibMem"}},{"before":"d992a05ade3d1bebc6e7a81aaf700286e0e217c8","after":"edc6681206c1a8791981a2f911d2fb8b3d2f5768","ref":"refs/heads/master","pushedAt":"2024-02-16T17:53:31.000Z","pushType":"push","commitsCount":991,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiCpuPkg/PiSmmCpuDxeSmm: fix NULL deref when gSmmBaseHobGuid is missing\n\nRef: https://bugzilla.tianocore.org/show_bug.cgi?id=4682\nFixes: 725acd0b9cc0\n\nBefore commit 725acd0b9cc0 (\"UefiCpuPkg: Avoid assuming only one\nsmmbasehob\", 2023-12-12), PiCpuSmmEntry() used to look up\n\"gSmmBaseHobGuid\", and allocate \"mCpuHotPlugData.SmBase\" regardless of the\nGUID's presence:\n\n> - mCpuHotPlugData.SmBase = (UINTN *)AllocatePool (sizeof (UINTN) * mMaxNumberOfCpus);\n> - ASSERT (mCpuHotPlugData.SmBase != NULL);\n\nAfter commit 725acd0b9cc0, PiCpuSmmEntry() -> GetSmBase() would allocate\n\"mCpuHotPlugData.SmBase\" only on the success path, and no allocation would\nbe performed on *any* of the error paths.\n\nThis caused a problem: if \"mCpuHotPlugData.SmBase\" was left NULL because\nthe GUID HOB was missing, PiCpuSmmEntry() would still be supposed to\nallocate \"mCpuHotPlugData.SmBase\", just like earlier. However, because\ncommit 725acd0b9cc0 conflated the two possible error modes (out of SMRAM,\nand no GUID HOB), PiCpuSmmEntry() could not decide whether it should\nallocate \"mCpuHotPlugData.SmBase\", or not. Currently, we never allocate if\nGetSmBase() fails -- for any reason --, which means that on platforms that\ndon't produce the GUID HOB, \"mCpuHotPlugData.SmBase\" is left NULL, leading\nto null pointer dereferences later, in PiCpuSmmEntry().\n\nNow that a prior patch in the series distinguishes the two error modes\nfrom each other, we can tell exactly when the GUID HOB is not found, and\nreinstate the earlier \"mCpuHotPlugData.SmBase\" allocation for that case.\n(With an actual error check thrown in, in addition to the original\n\"assertion\".)\n\nCc: Dun Tan \nCc: Gerd Hoffmann \nCc: Rahul Kumar \nCc: Ray Ni \nReported-by: Gerd Hoffmann \nSigned-off-by: Laszlo Ersek \nReviewed-by: Michael D Kinney \nReviewed-by: Leif Lindholm \nReviewed-by: Rahul Kumar \nReviewed-by: Gerd Hoffmann \nTested-by: Gerd Hoffmann ","shortMessageHtmlLink":"UefiCpuPkg/PiSmmCpuDxeSmm: fix NULL deref when gSmmBaseHobGuid is mis…"}},{"before":"932477379b186fe918348b6394b0978663e07ec6","after":null,"ref":"refs/heads/dependabot/pip/edk2-pytool-extensions-approx-eq-0.22.2","pushedAt":"2023-12-07T20:33:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"}},{"before":"908bacd314f877664580aab9848640f436928b83","after":null,"ref":"refs/heads/dependabot/pip/antlr4-python3-runtime-4.12.0","pushedAt":"2023-12-07T20:33:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"}},{"before":"65b97c62eb22afd2ca48b6a8b2f2da8b51bebc55","after":null,"ref":"refs/heads/temp/uefipayload_flexible_debug","pushedAt":"2023-12-07T20:20:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"}},{"before":"4b4c05f395c97ff9df701d5701efd86a03681fa8","after":"a29dd908ab576a07d4ee635ad51416cec2577d74","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-07-08T12:20:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset eight](https://review.coreboot.org/c/coreboot/+/74121/8) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"9dfec7311d7777b72e89f310fa0ce437293dcf68","after":"4b4c05f395c97ff9df701d5701efd86a03681fa8","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-07-08T11:02:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset eight](https://review.coreboot.org/c/coreboot/+/74121/8) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"1b75f83557b5a188baae198bd30b72c5cfea85b5","after":"9dfec7311d7777b72e89f310fa0ce437293dcf68","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-26T17:10:40.319Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset eight](https://review.coreboot.org/c/coreboot/+/74121/8) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"d197cba67c86a4009a46aacc1a9c70fe5626999e","after":"1b75f83557b5a188baae198bd30b72c5cfea85b5","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-24T04:12:31.358Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset seven](https://review.coreboot.org/c/coreboot/+/74121/7) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"e9d81607e446692fe4673e6dfd1488be0bfcd468","after":"d197cba67c86a4009a46aacc1a9c70fe5626999e","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-24T00:43:42.136Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset seven](https://review.coreboot.org/c/coreboot/+/74121/7) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"62b8fc1f63446a3ffa62617f9b8999dc7a45f567","after":"e9d81607e446692fe4673e6dfd1488be0bfcd468","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-24T00:28:50.032Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset seven](https://review.coreboot.org/c/coreboot/+/74121/7) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"07e2961c2ae682625e027ca388d9dbafed04e583","after":"62b8fc1f63446a3ffa62617f9b8999dc7a45f567","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-24T00:26:35.654Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset seven](https://review.coreboot.org/c/coreboot/+/74121/7) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"f233b64e970554a03fc17665fc5d337872cbd982","after":"07e2961c2ae682625e027ca388d9dbafed04e583","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-12T17:39:54.725Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset five](https://review.coreboot.org/c/coreboot/+/74121/5) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"671238c87a1acacbfafbb16c88dab5607e0017d0","after":"f233b64e970554a03fc17665fc5d337872cbd982","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-09T23:23:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset five](https://review.coreboot.org/c/coreboot/+/74121/5) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"d105c8a3a0d9b7030fc4d9734b8d71e243c52c5e","after":"671238c87a1acacbfafbb16c88dab5607e0017d0","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-09T23:03:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset five](https://review.coreboot.org/c/coreboot/+/74121/5) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"873b8634eca45cb98f08a475cfd421a615e187ca","after":"d105c8a3a0d9b7030fc4d9734b8d71e243c52c5e","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-05T04:48:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset five](https://review.coreboot.org/c/coreboot/+/74121/5) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"f23c3551aaa430abae3a76156b748e7e58f6defc","after":"873b8634eca45cb98f08a475cfd421a615e187ca","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-05-05T04:41:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset five](https://review.coreboot.org/c/coreboot/+/74121/5) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nWill review for production-quality later.\n\nSome notes:\n- Forms are flattened, with UI name produced as subtitle. It is\n possible, though maybe difficult to improve.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"67a6f414aa0e2a9cac965fcc6d83b6cbd6e893c0","after":"d992a05ade3d1bebc6e7a81aaf700286e0e217c8","ref":"refs/heads/master","pushedAt":"2023-05-05T02:48:14.000Z","pushType":"push","commitsCount":127,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg.\n\nAdd more maintainers and reviewers for these 2 packages.\n\nCc: Nate DeSimone \nCc: Duggapu Chinni B \nCc: Ray Han Lim Ng \nCc: Chen Gang C \nCc: Star Zeng \nCc: Ted Kuo \nCc: Ashraf Ali S \nCc: Susovan Mohapatra \nSigned-off-by: Chasel Chiu \nReviewed-by: Duggapu Chinni B \nReviewed-by: Ng Ray Han Lim \nReviewed-by: Chen Gang C \nReviewed-by: Kuo Ted \nReviewed-by: Mohapatra Susovan \nReviewed-by: S Ashraf Ali ","shortMessageHtmlLink":"Maintainers.txt: Update for IntelFsp2Pkg and IntelFsp2WrapperPkg."}},{"before":null,"after":"65b97c62eb22afd2ca48b6a8b2f2da8b51bebc55","ref":"refs/heads/temp/uefipayload_flexible_debug","pushedAt":"2023-05-05T02:47:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Use clearer debug flags with more flexibility\n\nThe default behaviour is that RELEASE builds have all DebugLib macros\nremoved by MDEPKG_NDEBUG. Currently, UefiPayloadPkg has been using\nUSE_CBMEM_FOR_CONSOLE to disable this behaviour, but it's unclear that\nthis option changes DEBUG build behaviour too.\n\nTherefore, add a new build flag, RELEASE_LOGGING, that can be used\nto set the logging behaviour. The USE_CBMEM_FOR_CONSOLE flag only\nselects the library and options specific to it. For instance, logs can\nonly be retrieved when the boot completes, so do not produce a CPU\nbreakpoint or deadloop in this case.\n\nThere are also cases where the platform builder may want behaviour or\ninformation from the DEBUG_CODE macros. Therefore, separate this into\nanother build flag.\n\nBitwise ORs enable this flexibility.\n\nCc: Guo Dong \nCc: Ray Ni \nCc: Sean Rhodes \nCc: James Lu \nCc: Gua Guo \nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Use clearer debug flags with more flexibility"}},{"before":"927baebea71737b7510e0547c62710400a8112aa","after":"f23c3551aaa430abae3a76156b748e7e58f6defc","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-04-21T00:45:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Implement support for initial bootloader CFR records\n\nCFR is a new mechanism where bootloaders can provide a list of options\nto be parsed as an option menu. This EDK2 implementation will produce a\nsetup menu at runtime.\n\nDeveloped against [patchset one](https://review.coreboot.org/c/coreboot/+/74121/1) of the CFR format.\nCFR is still an RFC, this patch requires updates to stay synced.\n\nSome notes:\n- CFR option flags not processed completely - grayout and suppress.\n- CFR forms not emitted individually, this might be difficult. Instead,\n consider subtitle separators.\n- Currently, form generated on the frontpage. It's platform-specific,\n let's retry adding in the Device Manager UI.\n- String parsing may not be optimal or sufficiently hardened.\n - Other methods to obtain the variable name were considered, all have\n down-sides. Nevertheless, this can be reconsidered later.\n- May require optimisation. For instance, extensive use of pools and\n frequent recomputations in HII config routing.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Implement support for initial bootloader CFR records"}},{"before":"6c020ae1dd446a641732876e5efa4fa7d030fcaa","after":"927baebea71737b7510e0547c62710400a8112aa","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-04-02T02:05:22.000Z","pushType":"push","commitsCount":42,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"UefiPayloadPkg: Update default memory type information for S4\n\nCopied values from OVMF, these are sufficient for a debug build.\n\nNow that those are improved, remove\nPcdResetOnMemoryTypeInformationChange override. If the memory map must\nchange, reset system so that an S4 resume will succeed.\n\nRequires testing a hibernate resume to OS.\n\nCc: Guo Dong \nCc: Ray Ni \nCc: Sean Rhodes \nCc: James Lu \nCc: Gua Guo \nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"UefiPayloadPkg: Update default memory type information for S4"}},{"before":null,"after":"291e175671a1a624d789d588c754c1917233c3f7","ref":"refs/heads/dev/unified","pushedAt":"2023-04-01T22:05:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"[WIP] MdeModulePkg: Add new SerialPortLibMem\n\nSerialPortLibMem is an implementation of a SerialPortLib designed for\nobtaining debug messages in commercial systems or where debug\nfacilities might otherwise be restricted. It writes to a memory buffer\nand writes the address and offsets to variables at ExitBootServices()\nfor the user's convenience.\n\nThe PEI instance initially creates a small buffer, due to temporary\nmemory size restrictions, but may create and move to a larger buffer at\nPeiMemoryDiscovered. The DXE instance will copy the HOB to its own\nallocation to eventually provide to the user.\n\nThe SMM instance validates and uses the DXE instance's buffer. Further\nconsideration is required for the security of this phase.\n\nCc: Jian J Wang \nCc: Liming Gao \nCc: Nate DeSimone \nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"[WIP] MdeModulePkg: Add new SerialPortLibMem"}},{"before":null,"after":"395c0736e9d5b8ec33d0bb8f1c298795e0886cb6","ref":"refs/heads/dev/minplatform","pushedAt":"2023-04-01T22:05:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"[WIP] MdeModulePkg/DxeCorePerformanceLib: Stash a local debug print\n\nIt seems MinPlatform builds are out-of-memory for performance\ninformation. Attempt to find out why later.\n\nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"[WIP] MdeModulePkg/DxeCorePerformanceLib: Stash a local debug print"}},{"before":null,"after":"6c020ae1dd446a641732876e5efa4fa7d030fcaa","ref":"refs/heads/dev/uefipayload","pushedAt":"2023-04-01T22:05:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"benjamindoron","name":"Benjamin Doron","path":"/benjamindoron","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9547650?s=80&v=4"},"commit":{"message":"[WIP] UefiPayloadPkg: Support SMRAMC register\n\nFormer Intel platforms controlled SMRAM protection using a dedicated\nregister.\n\nSlimBootloader-supported platforms have converged on the SMRR, but for\ncoreboot to support prior platforms too, lock-down is advised.\n\nRequires testing.\n\nCc: Guo Dong \nCc: Ray Ni \nCc: Sean Rhodes \nCc: James Lu \nCc: Gua Guo \nSigned-off-by: Benjamin Doron ","shortMessageHtmlLink":"[WIP] UefiPayloadPkg: Support SMRAMC register"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD_NtgCAA","startCursor":null,"endCursor":null}},"title":"Activity · benjamindoron/edk2"}