Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.29.8-151-g765e6ecf32 breaks BKB/Lingua-JA-Moji-0.56.tar.gz #24

Closed
andk opened this issue Mar 31, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@andk
Copy link

commented Mar 31, 2019

As per subject. Link to bleadperl commit: https://perl5.git.perl.org/perl.git/commit/765e6ecf32

Sample fail report: http://www.cpantesters.org/cpan/report/e0548520-4eb9-11e9-b882-34ceec8ecb8d

I will also open an issue on perlbug and post the link here.

@andk

This comment has been minimized.

Copy link
Author

commented Mar 31, 2019

Here is a link to the perlbug issue. I hope it helps: https://rt.perl.org/Ticket/Display.html?id=133968

Regards,

@benkasminbullock

This comment has been minimized.

Copy link
Owner

commented Mar 31, 2019

I'm fairly confident that this is a bug in Perl, not in my module. There is a blog post here:

http://blogs.perl.org/users/ben_bullock/2019/03/what-to-do-with-doubly-broken-utf-8.html

The thing which Perl 5.29 gets as the first match is "ック" but the regex here:

https://metacpan.org/source/BKB/Lingua-JA-Moji-0.56/lib/Lingua/JA/Moji.pm#L1404

should match the initial "ソー". Without carefully inspecting the code, the most likely suspect here is probably the "オ-モ" in the regex, which should match all the Unicode characters from オ to モ. Maybe KW forgot to include that in his thing.

@khwilliamson

This comment has been minimized.

Copy link
Contributor

commented Mar 31, 2019

This bug was already discovered by Slaven Rezic, and reported here
https://rt.perl.org/Ticket/Display.html?id=133942#txn-1621522
And it has already been fixed in blead, as further commentary in that ticket indicate.

Andreas, there have been several fixes to blead recently. It would be best to test with that instead of an older version.

@benkasminbullock

This comment has been minimized.

Copy link
Owner

commented Mar 31, 2019

I don't think the 0.56 test failures are a bug in my module, so I'll mark this issue as closed. If it's a bug in LJM, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.