New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak #10

Merged
merged 6 commits into from Aug 16, 2014

Conversation

Projects
None yet
2 participants
@gelisam
Copy link
Contributor

gelisam commented Aug 8, 2014

As posted on the mailing list.

@gelisam gelisam changed the title Leak demo Fix leak Aug 8, 2014

@benl23x5

This comment has been minimized.

Copy link

benl23x5 commented on 76020f6 Aug 10, 2014

Thanks for hunting this problem down, but we can't have naked calls to 'undefined' in production code. If the 'undefined' ever gets evaluated then the program will just die with "Prelude: undefined".

To fix this we'll need to refactor the code in a way that doesn't depend on 'undefined'.

This comment has been minimized.

Copy link
Owner

gelisam replied Aug 10, 2014

To fix this we'll need to refactor the code in a way that doesn't depend on 'undefined'.

This refactoring is precisely the purpose of the dead-code removing commits. The call to undefined has been removed by the commit which immediately follows this one, a85bbc7.

benl23x5 added a commit that referenced this pull request Aug 16, 2014

@benl23x5 benl23x5 merged commit 881d9c8 into benl23x5:master Aug 16, 2014

@benl23x5

This comment has been minimized.

Copy link
Owner

benl23x5 commented Aug 16, 2014

ok, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment