Added :tablet to mime types #11

Merged
merged 9 commits into from Feb 15, 2012

Projects

None yet

2 participants

@SentulAsia

Add support for :tablet mime types...

@benlangfeld benlangfeld commented on an outdated diff Feb 14, 2012
lib/mobile-fu.rb
end
end
module ActionController
module MobileFu
+ # These are various strings that can be found in mobile devices. Please feel free
+ # to add on to this list.
+ MOBILE_USER_AGENTS = 'palm|blackberry|nokia|phone|midp|mobi|symbian|chtml|ericsson|minimo|' +
@benlangfeld
benlangfeld Feb 14, 2012 Owner

I don't think this should be here. This is dealt with by the dependency on rack-mobile-detect.

@benlangfeld
Owner

Please merge recent changes to master here, specifically relating to the README

@SentulAsia

i've pushed latest commit without the mobile user agent with fixed readme to my master, shall i request to pull again?

@benlangfeld
Owner

You don't need a new pull request, you just need to push the changes to the same branch and they'll show up here.

@SentulAsia

i've googled on how to change the commit range but the 'Change Commits' button is not where it suppose to be... can i just close this issue and submit a new pull request?

@benlangfeld
Owner

Aha, your new commits are showing up now. Looks like your push failed. I'll merge this and do a little cleanup/release soon.

@benlangfeld benlangfeld merged commit db7420a into benlangfeld:master Feb 15, 2012
@SentulAsia

thanx! this is my first time contributing using fork.. huhu...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment