Use logging rather than print

In production under mod_wsgi, one can't write to stdout.

prints in management commands left untouched.

djangopypi/forms.py

@@ -1,3 +1,4 @@
+import logging
 from os.path import basename
 
 from django import forms
@@ -8,6 +9,8 @@
 from djangopypi.models import Package, Classifier, Release, Distribution
 
 
+log = logging.getLogger('djangopypi.forms')
+
 
 class SimplePackageSearchForm(forms.Form):
     query = forms.CharField(max_length=255)
@@ -31,7 +34,7 @@ def clean_content(self):
                                        filename=content.name)
 
         if not storage.exists(name):
-            print '%s does not exist' % (name,)
+            log.error('%s does not exist', name)
             return content
 
         if settings.DJANGOPYPI_ALLOW_VERSION_OVERWRITE:

djangopypi/signals.py

@@ -1,8 +1,11 @@
+import logging
+
 from django.db.models import signals
 from django.utils.hashcompat import md5_constructor
 
 from djangopypi.models import Package, Release, Distribution
 
+log = logging.getLogger('djangopypi.signals')
 
 def autohide_new_release_handler(sender, instance, created, *args, **kwargs):
     """ Autohide other releases on the creation of a new release when the 
@@ -50,8 +53,8 @@ def distribution_hash(sender, instance, *args, **kwargs):
             fh.close()
             instance.md5_digest = digest.hexdigest()
             instance.save()
-        except Exception, e:
-            print str(e)
+        except Exception:
+            log.exception("Error calculating hash")
 
 signals.post_save.connect(autohide_new_release_handler, sender=Release)
 signals.pre_save.connect(autohide_save_release_handler, sender=Release)

djangopypi/utils.py

@@ -1,5 +1,4 @@
-import sys, traceback
-
+import logging
 
 
 def debug(func):
@@ -8,5 +7,5 @@ def _wrapped(*args, **kwargs):
         try:
             return func(*args, **kwargs)
         except:
-            traceback.print_exception(*sys.exc_info())
-    return _wrapped
+            logging.exception("@debug")
+    return _wrapped

djangopypi/views/distutils.py

@@ -155,7 +155,7 @@ def register_or_upload(request):
                                                md5_digest=md5_digest)
     except Exception, e:
         transaction.rollback()
-        print str(e)
+        log.exception('Failure when storing upload')
 
     transaction.commit()