Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Hoedown #31

Closed
devinus opened this issue Oct 1, 2013 · 14 comments
Closed

Consider using Hoedown #31

devinus opened this issue Oct 1, 2013 · 14 comments

Comments

@devinus
Copy link

devinus commented Oct 1, 2013

I have revived Sundown into an improved library called Hoedown!

https://github.com/hoedown/hoedown

Here, I merged long languishing pull requests from Sundown, merged improvements from Redcarpet, merged improvements from Rinku and Houdini, greatly improved and standardized the API, and fixed many potential bugs.

Full list of changes: hoedown/hoedown@vmg:master...master

Sundown had a rich collection of bindings and it would truly be a shame if we couldn't all benefit from a single library in the future.

@mildsunrise
Copy link
Collaborator

Waiting until API v2 gets released to start migrating. ;)

@timoxley
Copy link

@devinus good news #32 (comment)

@mildsunrise
Copy link
Collaborator

I'd like to have working bindings before Hoedown v3.
The JavaScript API will change a lot. Together with the library change, it'll cause confusion.

So I suggest we deprecate this and create official Hoedown bindings for Node.
@devinus, can you create https://github.com/hoedown/node-hoedown?

@devinus
Copy link
Author

devinus commented Mar 25, 2014

@jmendeth Done.

@mildsunrise
Copy link
Collaborator

Wow, thanks! For some reason I can't push to it, though.
Maybe you should initialize it first. Dunno.

2014-03-25 18:57 GMT+01:00 Devin Torres notifications@github.com:

@jmendeth https://github.com/jmendeth Done.


Reply to this email directly or view it on GitHubhttps://github.com//issues/31#issuecomment-38598525
.

@mildsunrise
Copy link
Collaborator

I have pushed an initial commit to https://github.com/jmendeth/node-hoedown.git, can you push it to the official repo?

git clone https://github.com/jmendeth/node-hoedown.git && cd node-hoedown
git push https://github.com/hoedown/node-hoedown.git master

After that, I should be able to push to it as usual.

@devinus
Copy link
Author

devinus commented Mar 25, 2014

Done.

@timoxley
Copy link

👍 👍

@mildsunrise
Copy link
Collaborator

Oh, I just realized you need to add the repositories to the Contributors team. >.<

@devinus
Copy link
Author

devinus commented Mar 26, 2014

Done.

@mildsunrise
Copy link
Collaborator

Fine, I can now push to it. One last thing: could you update the repo's description to

Node.JS bindings for Hoedown

like in the temporary repo? That'd be all.

@devinus
Copy link
Author

devinus commented Mar 26, 2014

OK. Also, I've added collabs to the spec repo as well.

@mildsunrise
Copy link
Collaborator

Yeah, spec needs some love too.

@mildsunrise
Copy link
Collaborator

Done! 🎉 Already published in NPM, version 0.1.0 exposes all the API*
and features complete docs and some examples.

* Except the autolinker, I'm still not familiar with its API.

PD: @devinus it'd be interesting to use the node-hoedown's docs for the official ones, especially the flag / extension descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants