Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
`no-unused-modules` appveyor tests failing #1317
There's some appveyor tests failing due to #1142: https://ci.appveyor.com/project/benmosher/eslint-plugin-import/builds/23488849
What's particularly confusing is that a) they pass on travis and locally; b) one of the test cases is listed, identically, as both valid and invalid, so it shouldn't pass at all; there shouldn't be any filesystem impact, which means it shouldn't be failing on windows.
We need to get this fixed ASAP.
I was able to identify the problem for the failing tests. In line 465 I'm using
On macOS, the values in this field are looking like this:
I could imagine that this is just the normal behavior on Windows systems, as all these systems are using the backslash instead the slash in the file path. So the value itself is a valid file path on Windows systems. Only JS doesn't like the backslashes in it when passing around the value.
A solution for this problem could be to use the
referenced this issue
Apr 16, 2019
I digged into that a bit. It seems, that this behavior is coming from the parser, not eslint itself. Babel-eslint is giving back the path in the same format on macOS and Windows (with slashes instead of backslashes), while espree is giving back different formats.
I haven't yet found the code causing this behavior, but I will stay on it.