New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] add config entry point for TypeScript #1257

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@kirill-konshin
Copy link

kirill-konshin commented Jan 7, 2019

Fixes #1256

@ljharb ljharb changed the title Fix for #1256 [New] add config entry point for TypeScript Jan 7, 2019

@ljharb

ljharb approved these changes Jan 7, 2019

Copy link
Collaborator

ljharb left a comment

Seems reasonable

@kirill-konshin kirill-konshin force-pushed the kirill-konshin:master branch from 25b5497 to ea8b172 Jan 7, 2019

@kirill-konshin

This comment has been minimized.

Copy link

kirill-konshin commented Jan 7, 2019

There was a broken CI, I have pushed an update for that. Some tests are still failing, no idea why, since I did not touch anything existing...

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

6 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-3.7%) to 93.617% when pulling 25b5497 on kirill-konshin:master into 1cd82eb on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-0.07%) to 97.294% when pulling ea8b172 on kirill-konshin:master into 1cd82eb on benmosher:master.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 7, 2019

Tests are failing due to #1254.

@kirill-konshin

This comment has been minimized.

Copy link

kirill-konshin commented Jan 7, 2019

Whew ) will you merge with failing tests?

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 7, 2019

No, this will be blocked on fixing that.

@kirill-konshin

This comment has been minimized.

Copy link

kirill-konshin commented Jan 7, 2019

Okay, is there any ETA then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment