Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): Support typescript namespaces #1320

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@bradzacher
Copy link
Contributor

bradzacher commented Apr 12, 2019

Fixes #1300

  • Added nested export scope support
  • Fixed broken test on ESLint v3 caused by old typescript parser

@bradzacher bradzacher marked this pull request as ready for review Apr 12, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.2%) to 97.981% when pulling 5a1db48 on bradzacher:export-ts-namespaces into 405900e on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage increased (+0.1%) to 97.981% when pulling 988e12b on bradzacher:export-ts-namespaces into 70c3679 on benmosher:master.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Apr 12, 2019

Hmm, I just pushed up a commit to deal with "Fixed broken test on ESLint v3 caused by old typescript parser" by skipping the test on eslint < 4. Does that mean this PR fixes the test so it passes? If so, please rebase and revert my change in the process :-)

@bradzacher bradzacher force-pushed the bradzacher:export-ts-namespaces branch from 5a1db48 to 988e12b Apr 12, 2019

@ljharb

ljharb approved these changes Apr 12, 2019

Copy link
Collaborator

ljharb left a comment

Thanks!

@ljharb ljharb merged commit 8a4226d into benmosher:master Apr 12, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 97.981%
Details
@bradzacher

This comment has been minimized.

Copy link
Contributor Author

bradzacher commented Apr 12, 2019

@ljharb - rebased on top!

Yeah the error was happening because in the old version of typescript which got installed with eslint v3 produced a different AST, hence that case wasn't handled. Not sure why it worked fine on the PR then failed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.