Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support `parseForESLint` from custom parser #1435

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@JounQin
Copy link
Contributor

commented Aug 3, 2019

close #1433

@JounQin JounQin referenced this pull request Aug 3, 2019

Closed

Parse error in mdx files #1433

@coveralls

This comment has been minimized.

Copy link

commented Aug 3, 2019

Coverage Status

Coverage increased (+2.6%) to 97.897% when pulling 35a12f9 on JounQin:feat/parse_for_eslint into ebcf17c on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

commented Aug 3, 2019

Coverage Status

Coverage remained the same at 97.897% when pulling b3cb239 on JounQin:feat/parse_for_eslint into 989f6cc on benmosher:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Aug 3, 2019

Coverage Status

Coverage remained the same at 97.897% when pulling b3cb239 on JounQin:feat/parse_for_eslint into 989f6cc on benmosher:master.

@cdfa

This comment has been minimized.

Copy link

commented Aug 3, 2019

So I ran npm i -D JounQin/eslint-plugin-import#feat/parse_for_eslint, but it's not working. I looked for the utlis/parse.js file you modified and it seems to be located at node_modules/eslint-module-utils/parse.js, but it doesn't have your patch. How do I test it?

@JounQin

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

@cdfa There is no need to wait for this PR, I've exported parse from @rxts/eslint-plugin-mdx, you can simply upgrade to the latest version.

@cdfa

This comment has been minimized.

Copy link

commented Aug 3, 2019

Ah great!

Show resolved Hide resolved tests/src/core/parse.js Outdated
Show resolved Hide resolved utils/parse.js Outdated
@ljharb

ljharb approved these changes Aug 5, 2019

Copy link
Collaborator

left a comment

LGTM

@ljharb ljharb added the semver-minor label Aug 5, 2019

@ljharb ljharb merged commit 35a12f9 into benmosher:master Aug 5, 2019

3 of 5 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.897%
Details

@JounQin JounQin deleted the JounQin:feat/parse_for_eslint branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.