Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] `order`: add option pathGroupsExcludedImportTypes to allow ordering of external import types #1570

Merged
merged 1 commit into from Jan 2, 2020

Conversation

@Mairu
Copy link
Contributor

Mairu commented Dec 14, 2019

… ordering of external import types

To fix the issue #1565 and have no BC break I added a new option to also allow sorting of external imports.

Fixes #1565.

… ordering of external import types
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage decreased (-0.1%) to 96.211% when pulling 16ae652 on Mairu:pathGroupsExcludedImportTypes into 982493d on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage increased (+0.08%) to 96.322% when pulling 855748b on Mairu:pathGroupsExcludedImportTypes into 4e8960d on benmosher:master.

2 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage increased (+0.08%) to 96.322% when pulling 855748b on Mairu:pathGroupsExcludedImportTypes into 4e8960d on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage increased (+0.08%) to 96.322% when pulling 855748b on Mairu:pathGroupsExcludedImportTypes into 4e8960d on benmosher:master.

@osdiab

This comment has been minimized.

Copy link

osdiab commented Jan 1, 2020

@benmosher @ljharb bump

@ljharb ljharb changed the title [New] `order` rule: add option pathGroupsExcludedImportTypes to allow… [New] `order`: add option pathGroupsExcludedImportTypes to allow ordering of external import types Jan 1, 2020
@ljharb ljharb added the semver-minor label Jan 1, 2020
@ljharb ljharb force-pushed the Mairu:pathGroupsExcludedImportTypes branch from c9d1aef to 16ae652 Jan 2, 2020
@ljharb
ljharb approved these changes Jan 2, 2020
@ljharb ljharb merged commit 16ae652 into benmosher:master Jan 2, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.1%) to 96.211%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.