Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add LICENSE file to all npm packages #1595

Conversation

@opichals
Copy link
Contributor

opichals commented Jan 6, 2020

Together with a new npm release of the modified fodlers this fixes #1225

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2020

Coverage Status

Coverage increased (+1.6%) to 97.874% when pulling ed41b9c on opichals:copy-license-to-all-npm-packages-for-npm-publish into cd25d9d on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2020

Coverage Status

Coverage decreased (-0.2%) to 96.262% when pulling 000eb3e on opichals:copy-license-to-all-npm-packages-for-npm-publish into aed7a73 on benmosher:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2020

Coverage Status

Coverage decreased (-0.2%) to 96.262% when pulling 000eb3e on opichals:copy-license-to-all-npm-packages-for-npm-publish into aed7a73 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2020

Coverage Status

Coverage decreased (-0.2%) to 96.262% when pulling 000eb3e on opichals:copy-license-to-all-npm-packages-for-npm-publish into aed7a73 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 6, 2020

Coverage Status

Coverage decreased (-0.2%) to 96.262% when pulling 000eb3e on opichals:copy-license-to-all-npm-packages-for-npm-publish into aed7a73 on benmosher:master.

@@ -0,0 +1,22 @@
The MIT License (MIT)

This comment has been minimized.

Copy link
@ljharb

ljharb Jan 6, 2020

Collaborator

let's make these gitignored and copied in via prepublish from the root, rather than duplicating the content.

This comment has been minimized.

Copy link
@opichals

opichals Jan 8, 2020

Author Contributor

or better yet, what about making this a proper monorepo a use lerna@3 to deal with this.

This comment has been minimized.

Copy link
@ljharb

ljharb Jan 8, 2020

Collaborator

absolutely not; for one, we'd have to move all of our packages into some kind of "packages" dir, which is too much git churn; but also in my experience lerna simply does not work well beyond bootstrap and exec, and i have no interest in using it on additional projects.

@opichals opichals force-pushed the opichals:copy-license-to-all-npm-packages-for-npm-publish branch from 000eb3e to 9a71855 Jan 10, 2020
@opichals

This comment has been minimized.

Copy link
Contributor Author

opichals commented Jan 10, 2020

let's make these gitignored and copied in via prepublish from the root, rather than duplicating the content.

@ljharb addressed

@ljharb ljharb force-pushed the opichals:copy-license-to-all-npm-packages-for-npm-publish branch from 9a71855 to 1eb9303 Jan 10, 2020
@ljharb
ljharb approved these changes Jan 10, 2020
Copy link
Collaborator

ljharb left a comment

Thanks!

@ljharb ljharb force-pushed the opichals:copy-license-to-all-npm-packages-for-npm-publish branch 4 times, most recently from f650b17 to ed41b9c Jan 10, 2020
@ljharb ljharb merged commit ed41b9c into benmosher:master Jan 10, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.6%) to 97.874%
Details
@opichals

This comment has been minimized.

Copy link
Contributor Author

opichals commented Jan 13, 2020

@ljharb Thank you!

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 13, 2020

Every package should have been released at this point with the license, ftr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.