Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use createRequire instead of createRequireFromPath if available #1602

Merged
merged 1 commit into from Jan 11, 2020

Conversation

@iamnapo
Copy link
Contributor

iamnapo commented Jan 11, 2020

In order to avoid: DeprecationWarning: Module.createRequireFromPath() is deprecated. Use Module.createRequire() instead. when using Node >= v12.2.0.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 11, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling bcd9fe8 on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 11, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling d16dc0b on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 11, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling d16dc0b on iamnapo:module-deprecation-warning into d8c6795 on benmosher:master.

@ljharb
ljharb approved these changes Jan 11, 2020
Copy link
Collaborator

ljharb left a comment

Thanks, this looks great!

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 11, 2020

cc @arcanis as a heads up

@ljharb ljharb merged commit bcd9fe8 into benmosher:master Jan 11, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.874%
Details
@iamnapo iamnapo deleted the iamnapo:module-deprecation-warning branch Jan 12, 2020
@sodatea sodatea mentioned this pull request Jan 19, 2020
2 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.