Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the loader resolution more tolerant #1606

Merged
merged 1 commit into from Jan 12, 2020
Merged

Conversation

@arcanis
Copy link
Contributor

arcanis commented Jan 12, 2020

(Sorry @iamnapo, it was very late at night and I initially opened this PR against your repo ... 馃槄)

Assuming that the repro provided by #1604 (comment) will be valid, a simple solution would be to be too laxist for now and just fallback to the hoisting resolution if the file-relative one doesn't find the loader - while still using the expected resolution as primary code path.

And then the next time eslint-import-utils receives a major bump, revert the try/catch block and go back to using exclusively createRequire.

cc @ljharb, fixes #1604, fixes #1603

Fixes #1604. Fixes #1603.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2020

Coverage Status

Coverage decreased (-4.2%) to 93.717% when pulling 9773794 on arcanis:patch-3 into bcd9fe8 on benmosher:master.

4 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2020

Coverage Status

Coverage decreased (-4.2%) to 93.717% when pulling 9773794 on arcanis:patch-3 into bcd9fe8 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2020

Coverage Status

Coverage decreased (-4.2%) to 93.717% when pulling 9773794 on arcanis:patch-3 into bcd9fe8 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2020

Coverage Status

Coverage decreased (-4.2%) to 93.717% when pulling 9773794 on arcanis:patch-3 into bcd9fe8 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2020

Coverage Status

Coverage decreased (-4.2%) to 93.717% when pulling 9773794 on arcanis:patch-3 into bcd9fe8 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling cd14858 on arcanis:patch-3 into bcd9fe8 on benmosher:master.

utils/resolve.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the arcanis:patch-3 branch 2 times, most recently from 5ba72b1 to cd14858 Jan 12, 2020
@ljharb
ljharb approved these changes Jan 12, 2020
@ljharb ljharb merged commit cd14858 into benmosher:master Jan 12, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.874%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.