Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicated `Added` section in CHANGELOG #1609

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@pocke
Copy link
Contributor

pocke commented Jan 14, 2020

I found duplicated Added sections in CHANGELOG for the latest release.
This pull request will merge them into one.

By the way, I also found a missing link in the CHANGELOG.
It is the second line of "Fixed" section, "[import/extensions]: ignore non-main modules".
import/extensions does not link to anywhere.
But I'm not sure it should be "import/extensions setting" or extensions.
I'll fix the link in this pull request if you tell the right link and you'd like. Or feel free handling it yourself.

Thanks!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling 71e87da on pocke:tweak-changelog into 2c57742 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling cdaffb1 on pocke:tweak-changelog into 2c57742 on benmosher:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling cdaffb1 on pocke:tweak-changelog into 2c57742 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling cdaffb1 on pocke:tweak-changelog into 2c57742 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 97.874% when pulling cdaffb1 on pocke:tweak-changelog into 2c57742 on benmosher:master.

@ljharb ljharb force-pushed the pocke:tweak-changelog branch from cdaffb1 to 71e87da Jan 14, 2020
@ljharb
ljharb approved these changes Jan 14, 2020
Copy link
Collaborator

ljharb left a comment

Thanks! I fixed the link as well.

@ljharb ljharb merged commit 71e87da into benmosher:master Jan 14, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.874%
Details
@pocke pocke deleted the pocke:tweak-changelog branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.