Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.20.1 #1641

Merged
merged 23 commits into from Feb 2, 2020
Merged

v2.20.1 #1641

merged 23 commits into from Feb 2, 2020

Conversation

@ljharb
Copy link
Collaborator

ljharb commented Feb 2, 2020

See #1513 for failing appveyor tests.

kentcdodds and others added 23 commits Aug 7, 2019
…orts from a `node_modules` module

Fixes #1446.
This test was added and skipped in #794 (probably since it was failing then), but it's not failing anymore on current master
Fixes #1597
Fixes #1604. Fixes #1603.
Fixes #1598.
It is a syntax error to put both namespace and non namespace import on the same line, so allow it.

Fixes #1538
…not crash

Fixes #1613
This PR adds [eslint-plugin-eslint-plugin](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin) (a popular plugin for linting eslint plugins), enables relevant rules from it, and fixes violations.

The primary changes included are:
1. Adds missing rule schemas ([require-meta-schema](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-schema.md)). Note that `schema: []` is added to enforce when a rule should have no schema.
2. Adds missing rule `type` property to `no-unused-modules` rule ([require-meta-type](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-type.md)).
3. Removes duplicate test cases ([no-identical-tests](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/no-identical-tests.md)).
Fixes #1625
…uire test case output assertions

Use the more strict option for this internal lint rule.

If a rule has no autofix, we should assert that there is no output. All of the test cases I fixed have no autofix, so the output matches the input. In eslint > v2, we can switch to `output: null` to represent this, and re-enable the `eslint-plugin/prefer-output-null` internal lint rule.

https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/consistent-output.md
https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/prefer-output-null.md
Searched using cspell.
Fixes #1635.
Fixes #1616
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.838% when pulling 45f0860 on ljharb:release-2.20.1 into 8001916 on benmosher:release.

5 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.838% when pulling 45f0860 on ljharb:release-2.20.1 into 8001916 on benmosher:release.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.838% when pulling 45f0860 on ljharb:release-2.20.1 into 8001916 on benmosher:release.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.838% when pulling 45f0860 on ljharb:release-2.20.1 into 8001916 on benmosher:release.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.838% when pulling 45f0860 on ljharb:release-2.20.1 into 8001916 on benmosher:release.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 2, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.838% when pulling 45f0860 on ljharb:release-2.20.1 into 8001916 on benmosher:release.

@ljharb ljharb merged commit 45f0860 into benmosher:release Feb 2, 2020
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.04%) to 97.838%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ljharb ljharb deleted the ljharb:release-2.20.1 branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

You can’t perform that action at this time.