Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print more helpful info if parsing fails #1671

Merged
merged 1 commit into from Mar 3, 2020
Merged

Conversation

@kaiyoma
Copy link
Contributor

kaiyoma commented Mar 1, 2020

If parsing fails, the only message printed to the console is vague and
mostly unhelpful. Print some information about the source of the error
to make debugging easy.

If parsing fails, the only message printed to the console is vague and
mostly unhelpful. Print some information about the source of the error
to make debugging easy.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling adbced7 on kaiyoma:error-logging into b6242b0 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling 9364093 on kaiyoma:error-logging into b6242b0 on benmosher:master.

5 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling 9364093 on kaiyoma:error-logging into b6242b0 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling 9364093 on kaiyoma:error-logging into b6242b0 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling 9364093 on kaiyoma:error-logging into b6242b0 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling 9364093 on kaiyoma:error-logging into b6242b0 on benmosher:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-0.04%) to 97.796% when pulling 9364093 on kaiyoma:error-logging into b6242b0 on benmosher:master.

@ljharb
ljharb approved these changes Mar 3, 2020
@ljharb ljharb merged commit adbced7 into benmosher:master Mar 3, 2020
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.04%) to 97.796%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.