New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated flags to imports-first metadata #625

Merged
merged 1 commit into from Nov 2, 2016

Conversation

Projects
None yet
4 participants
@randycoulman
Copy link
Contributor

randycoulman commented Oct 14, 2016

Over on eslint-find-rules, there has been some discussion about being able to detect deprecated rules in order to not report them as unused and to report when they are still being used.

In order to implement those features, there needs to be a way to detect that a rule has been deprecated. Core ESLint rules that are deprecated are marked as such in their metadata.

This PR adds the same deprecated flag to the metadata of the deprecated rule in this plugin.

I added a very specific spec for this rule to make sure that imports-first is marked as deprecated, but first (which is its new name) is not. There might be a better way to write a more generic test, but when there’s only a single deprecated rule, it’s hard to know what the right direction is.

@jfmengels
Copy link
Collaborator

jfmengels left a comment

Sounds good to me!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 14, 2016

Coverage Status

Coverage increased (+0.01%) to 94.91% when pulling 52327ac on randycoulman:add-deprecated-to-metadata into d9605a0 on benmosher:master.

@benmosher
Copy link
Owner

benmosher left a comment

👍🏻 thanks! Didn't realize this was out in the wild!

@jfmengels

This comment has been minimized.

Copy link
Collaborator

jfmengels commented Oct 23, 2016

@benmosher Any reason you didn't merge this? I'm 👍 with this

@benmosher benmosher merged commit 2602b5d into benmosher:master Nov 2, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 94.91%
Details

@randycoulman randycoulman deleted the randycoulman:add-deprecated-to-metadata branch Jul 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment