From d37a7bd9256591819772b0c01fe231c02eda406e Mon Sep 17 00:00:00 2001 From: Benny Megidish Date: Tue, 17 May 2022 13:29:16 +0300 Subject: [PATCH] fix: added missing dependencies #146, #166 --- package.json | 2 -- packages/nx-electron/package.json | 8 ++++++-- packages/nx-electron/src/utils/electron.config.ts | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 18815f2..df96824 100644 --- a/package.json +++ b/package.json @@ -16,8 +16,6 @@ }, "private": true, "devDependencies": { - "@angular-devkit/core": "^13.3.4", - "@angular-devkit/schematics": "^13.3.4", "@nrwl/angular": "13.10.3", "@nrwl/cli": "13.10.3", "@nrwl/devkit": "13.10.3", diff --git a/packages/nx-electron/package.json b/packages/nx-electron/package.json index b718b97..e7ca606 100644 --- a/packages/nx-electron/package.json +++ b/packages/nx-electron/package.json @@ -1,6 +1,6 @@ { "name": "nx-electron", - "version": "13.1.0", + "version": "13.1.1", "main": "src/index.js", "description": "Electron Plugin for Nx", "author": "Benny Megidish", @@ -46,10 +46,14 @@ "executors" ], "peerDependencies": { - "@nrwl/workspace": "^13", "electron": "*" }, "dependencies": { + "@angular-devkit/schematics": "^13", + "@nrwl/devkit": "^13", + "@nrwl/jest": "^13", + "@nrwl/linter": "^13", + "@nrwl/workspace": "^13", "circular-dependency-plugin": "^5.2.2", "copy-webpack-plugin": "^10.2.4", "electron-builder": "^22.14.13", diff --git a/packages/nx-electron/src/utils/electron.config.ts b/packages/nx-electron/src/utils/electron.config.ts index 46c057e..11cfcfd 100644 --- a/packages/nx-electron/src/utils/electron.config.ts +++ b/packages/nx-electron/src/utils/electron.config.ts @@ -1,4 +1,4 @@ -import { appRootPath } from '@nrwl/tao/src/utils/app-root'; +import { workspaceRoot } from '@nrwl/devkit'; import { Configuration } from 'webpack'; import { merge } from 'webpack-merge'; import nodeExternals from 'webpack-node-externals'; @@ -51,7 +51,7 @@ function getElectronPartial(options: BuildElectronBuilderOptions): Configuration } if (options.externalDependencies === 'all') { - const modulesDir = `${appRootPath}/node_modules`; + const modulesDir = `${workspaceRoot}/node_modules`; webpackConfig.externals = [nodeExternals({ modulesDir })]; } else if (Array.isArray(options.externalDependencies)) { webpackConfig.externals = [