Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some more dialyzer things #81

Merged
merged 5 commits into from Jun 27, 2013

Conversation

Projects
None yet
2 participants
Contributor

puzza007 commented Nov 21, 2012

Thanks for the replication fix! Here are a few dialyzer things.

@benoitc benoitc commented on the diff Dec 22, 2012

src/couchbeam_view.erl
@@ -323,75 +323,75 @@ parse_view_options(Options) ->
parse_view_options([], Args) ->
Args;
parse_view_options([{key, Value}|Rest], #view_query_args{options=Opts}=Args) ->
- Opts1 = [{"key", couchbeam_ejson:encode(Value)}|Opts],
@benoitc

benoitc Dec 22, 2012

Owner

why this change?

@puzza007

puzza007 Jan 2, 2013

Contributor

Only atoms are used (by couchbase) for option keys.

benoitc added a commit that referenced this pull request Jun 27, 2013

@benoitc benoitc merged commit 21c44d5 into benoitc:master Jun 27, 2013

1 check passed

default The Travis build passed
Details

@puzza007 puzza007 deleted the unknown repository branch Jun 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment