Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
does not work HTTPS on gunicorn 19.3.0 and tornado 4.3 #1135
I'm not sure this is a problem on gunicorn, but please ask a question here.
If someone point out the cause of this is which one gunicorn or tornado, it would be great help to me.
here is a starting command line.
and stacktrace is following:
sorry, I edited this comment because my previous comment was wrong. Your suggestion made perfect! Thank you so much!
*** /home/hiro/.virtualenvs/CP275_asyncproxy/lib/python2.7/site-packages/gunicorn/workers/gtornado_.py 2015-10-28 10:54:14.405533346 +0900 --- /home/hiro/.virtualenvs/CP275_asyncproxy/lib/python2.7/site-packages/gunicorn/workers/gtornado.py 2015-10-28 10:34:09.014425348 +0900 *************** *** 3,8 **** --- 3,9 ---- # This file is part of gunicorn released under the MIT license. # See the NOTICE for more information. + import copy import os import sys *************** *** 89,96 **** server_class = _HTTPServer if self.cfg.is_ssl: server = server_class(app, io_loop=self.ioloop, ! ssl_options=self.cfg.ssl_options) else: server = server_class(app, io_loop=self.ioloop) --- 90,100 ---- server_class = _HTTPServer if self.cfg.is_ssl: + _ssl_opt = copy.deepcopy(self.cfg.ssl_options) + del _ssl_opt["do_handshake_on_connect"] + del _ssl_opt["suppress_ragged_eofs"] server = server_class(app, io_loop=self.ioloop, ! ssl_options=_ssl_opt) else: server = server_class(app, io_loop=self.ioloop)
pushed a commit
Oct 28, 2015
It seems tornado side does not want to allow do_handshake_on_connect option and allow_ragged_eofs.
I'm not sure which side should accept the change.
Unfortunately, no, we can't use it.
That looks like a good idea to me. I've opened #1140.