test_factory in test_gaiohttp fails on 3.4+ #1164

Closed
berkerpeksag opened this Issue Dec 15, 2015 · 5 comments

Projects

None yet

3 participants

@berkerpeksag
Collaborator

Here's the output: https://travis-ci.org/benoitc/gunicorn/jobs/96861325

I haven't had a chance to investigate this further, could it be related to aiohttp?

@benoitc
Owner
benoitc commented Dec 23, 2015

maybe we should upgrade gaihttp requirements ? cc @asvetlov

@benoitc benoitc added a commit that referenced this issue Dec 28, 2015
@benoitc fix gaiohttp test
fix #1164
5bd8ebf
@benoitc
Owner
benoitc commented Dec 28, 2015

@berkerpeksag change above fix it. Let me know what you think about it.

@benoitc benoitc added a commit that referenced this issue Dec 28, 2015
@benoitc fix gaiohttp test
fix #1164
ec77df9
@berkerpeksag
Collaborator

@benoitc looks good, but it contains unrelated changes from #1168.

@benoitc
Owner
benoitc commented Dec 28, 2015

yeah wanted that all tests pass :)

@benoitc benoitc added a commit that closed this issue Dec 28, 2015
@benoitc fix gaiohttp test
fix #1164
3fdc113
@benoitc benoitc closed this in 3fdc113 Dec 28, 2015
@asvetlov
Collaborator

The fix looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment