New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_factory in test_gaiohttp fails on 3.4+ #1164

Closed
berkerpeksag opened this Issue Dec 15, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@berkerpeksag
Collaborator

berkerpeksag commented Dec 15, 2015

Here's the output: https://travis-ci.org/benoitc/gunicorn/jobs/96861325

I haven't had a chance to investigate this further, could it be related to aiohttp?

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Dec 23, 2015

Owner

maybe we should upgrade gaihttp requirements ? cc @asvetlov

Owner

benoitc commented Dec 23, 2015

maybe we should upgrade gaihttp requirements ? cc @asvetlov

benoitc added a commit that referenced this issue Dec 28, 2015

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Dec 28, 2015

Owner

@berkerpeksag change above fix it. Let me know what you think about it.

Owner

benoitc commented Dec 28, 2015

@berkerpeksag change above fix it. Let me know what you think about it.

benoitc added a commit that referenced this issue Dec 28, 2015

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Dec 28, 2015

Collaborator

@benoitc looks good, but it contains unrelated changes from #1168.

Collaborator

berkerpeksag commented Dec 28, 2015

@benoitc looks good, but it contains unrelated changes from #1168.

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Dec 28, 2015

Owner

yeah wanted that all tests pass :)

Owner

benoitc commented Dec 28, 2015

yeah wanted that all tests pass :)

@benoitc benoitc closed this in 3fdc113 Dec 28, 2015

@asvetlov

This comment has been minimized.

Show comment
Hide comment
@asvetlov

asvetlov Dec 29, 2015

Collaborator

The fix looks good.

Collaborator

asvetlov commented Dec 29, 2015

The fix looks good.

fofanov pushed a commit to fofanov/gunicorn that referenced this issue Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment