New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in log message when changing listeners on reload #1181

Closed
MarSoft opened this Issue Jan 9, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@MarSoft
Contributor

MarSoft commented Jan 9, 2016

When arbiter reloads workers on SIGHUP, and if old address is different from new address, it creates new sockets and logs about that. (https://github.com/benoitc/gunicorn/blob/master/gunicorn/arbiter.py#L402)

self.log.info("Listening at: %s", ",".join(str(self.LISTENERS)))

it takes a list, converts it to str and then joins resulting string with ,. Resulting log message is as follows:

[INFO] Listening at: [,<,g,u,n,i,c,o,r,n,.,s,o,c,k,.,T,C,P,S,o,c,k,e,t, ,o,b,j,e,c,t, ,a,t, ,0,x,7,f,8,e,3,d,2,1,f,7,8,0,>,]

Seems that this line should look like this:

self.log.info("Listening at: %s", ",".join(map(str, self.LISTENERS)))

Or maybe it should be made like on line 132 (in Arbiter.start).

MarSoft added a commit to MarSoft/gunicorn that referenced this issue Jan 9, 2016

@benoitc benoitc closed this in #1182 Jan 22, 2016

fofanov pushed a commit to fofanov/gunicorn that referenced this issue Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment