Error in log message when changing listeners on reload #1181

Closed
MarSoft opened this Issue Jan 9, 2016 · 0 comments

Projects

None yet

1 participant

@MarSoft
Contributor
MarSoft commented Jan 9, 2016

When arbiter reloads workers on SIGHUP, and if old address is different from new address, it creates new sockets and logs about that. (https://github.com/benoitc/gunicorn/blob/master/gunicorn/arbiter.py#L402)

self.log.info("Listening at: %s", ",".join(str(self.LISTENERS)))

it takes a list, converts it to str and then joins resulting string with ,. Resulting log message is as follows:

[INFO] Listening at: [,<,g,u,n,i,c,o,r,n,.,s,o,c,k,.,T,C,P,S,o,c,k,e,t, ,o,b,j,e,c,t, ,a,t, ,0,x,7,f,8,e,3,d,2,1,f,7,8,0,>,]

Seems that this line should look like this:

self.log.info("Listening at: %s", ",".join(map(str, self.LISTENERS)))

Or maybe it should be made like on line 132 (in Arbiter.start).

@MarSoft MarSoft added a commit to MarSoft/gunicorn that referenced this issue Jan 9, 2016
@MarSoft MarSoft Fixed log message for listener reloading
Fixes #1181
46da49f
@benoitc benoitc closed this in #1182 Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment