License and notice should be included in the Pypi wheel #1322

Closed
pombredanne opened this Issue Aug 4, 2016 · 8 comments

Projects

None yet

4 participants

@pombredanne
Contributor

This requires a simple manifest change in setup.cfg:

[metadata]
license_file = LICENSE

Unfortunately for now because of https://bitbucket.org/pypa/wheel/issues/138/include-more-than-one-license-file-or the NOTICE cannot be included too with the LICENSE, short of making these package data. This is still the case @dholth ?

One way out is to write a script to combine these at wheel/build time. Another is to concat LICENSE and NOTICE in a single LICENSE file.

@berkerpeksag
Collaborator

They both included in MANIFEST.in. Do you know why it doesn't work with bdist_wheel?

@pombredanne
Contributor

@berkerpeksag See the link to the wheel "bug" above. wheels have some level of disrespect for MANIFEST.in

@dholth
dholth commented Aug 4, 2016

MANIFEST.in is about the sdist contents. Would 'setup.py install' copy your license and notice into site-packages? If not, then bdist_wheel won't include them.

@dholth
dholth commented Aug 4, 2016

@pombredanne did you get my e-mail about including more files in wheel? Please comment.

@pombredanne
Contributor

@dholth sorry, I have not. I can be reached @ pombredanne@gmail.com and pombredanne@nexb.com

@benoitc
Owner
benoitc commented Aug 8, 2016

We won't for sure concat the license and the notice file. This is something that should be addressed by the package system.

Is the notice file shipped whit the package? how can we do it now without waiting for a possible change upstream?

@pombredanne pombredanne added a commit to pombredanne/gunicorn that referenced this issue Aug 8, 2016
@pombredanne pombredanne Include LICENSE for built wheels #1322 4c8cadc
@pombredanne
Contributor

@benoitc you can at least include the LICENSE file as suggested above: #1322 (comment) and in this simple PR #1326
To get both files in the wheel you would need to include them as package data I think?

@benoitc
Owner
benoitc commented Oct 16, 2016

pr applied

@benoitc benoitc closed this Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment