pidfile naming changed on 19.6.0 #1382

Closed
tbarbugli opened this Issue Nov 3, 2016 · 6 comments

Projects

None yet

4 participants

@tbarbugli

The pidfile postfix for the cycled process changed from .oldbin to .2. Perhaps I am the only soul on this planet to rely on this but having that mentioned in the changelog was going to save me a couple of hours for sure :)

My restart flow works like this:

  • kill USR2 to pid stored in pidfile
  • sleep 10s
  • kill TERM to pid.oldbin
@benoitc
Owner
benoitc commented Nov 6, 2016

The ticket describing the change was linked in the changelog:
http://docs.gunicorn.org/en/stable/news.html#core-logging

I'm not sure how more descriptive we could have been ...

@tbarbugli

Something like "pidfile name changed for USR2 reloads (link to issue)" perhaps? I guess not many people will be affected by this (how common is what I do for reloads?). For the ones that are affected this is going to be painful though

@benoitc
Owner
benoitc commented Nov 6, 2016

Maybe.

Anyway I will add a note on the signals doc about it to notice the change. I'm keeping the ticket open until it's done.

@tilgovi
Collaborator
tilgovi commented Dec 20, 2016

@tbarbugli if you would like to leave a PR, I would be happy to merge it!

@berkerpeksag berkerpeksag added a commit to berkerpeksag/gunicorn that referenced this issue Jan 23, 2017
@berkerpeksag berkerpeksag Document pidfile naming format change in 19.6.0
Fixes #1382
07b2a9a
@berkerpeksag
Collaborator

I'm going to merge #1444 unless there are no objections.

@berkerpeksag berkerpeksag added a commit to berkerpeksag/gunicorn that referenced this issue Jan 23, 2017
@berkerpeksag berkerpeksag Document pidfile naming format change in 19.6.0
Fixes #1382
b712c68
@tilgovi
Collaborator
tilgovi commented Jan 23, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment