New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the use SO_REUSE_PORT optional #1603

Closed
benoitc opened this Issue Sep 18, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@benoitc
Owner

benoitc commented Sep 18, 2017

This ticket supersedes #1553 . I also think this should be optional, there are some case where w don't want to reuse a port and it should probably be used implicitly.

The change looks easy:
https://github.com/benoitc/gunicorn/blob/master/gunicorn/sock.py#L42-L47

Thoughts?

@benoitc

This comment has been minimized.

Owner

benoitc commented Sep 18, 2017

just linking an old discussion about it #1131 (comment) for the record.

@tilgovi

This comment has been minimized.

Collaborator

tilgovi commented Sep 20, 2017

👍 already has access to the config object, too. Seems straightforward.

@btubbs

This comment has been minimized.

btubbs commented Sep 27, 2017

I've had a number of times where a zombie Gunicorn process was running at the same time as the one I was developing, but I didn't know it. If disabling SO_REUSEPORT by default would make such situations fail fast with a "port already in use" error instead of silently pretending that everything's OK, that would be a plus for me.

@tilgovi

This comment has been minimized.

Collaborator

tilgovi commented Dec 10, 2017

Let's do it. Adding the Help Wanted label.

@martinbroadhurst

This comment has been minimized.

Contributor

martinbroadhurst commented Dec 28, 2017

I have submitted a PR for this: #1669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment