Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Close File Handles on HUP Signal #627
This is related to #624 (comment). Please let me know if any additional details are required, or if I can assist in some way.
I first proposed closing explicitly, but probably not the best way to do it. Another option is to hold on to the same logger object, and just update the cfg, and call reopen on it? This is probably more complicated though...
The issue was first noticed on CentOS release 6.4 (Final) x86_64 machine, it can still be reproduced on that os, it has sporadically failed on OS X 10.8:
The reason I think this doesn't have to do with close_on_exec, is because the Master process doesn't get recreated when HUP signal is received, only the workers. So I am thinking that close_on_exec doesn't apply in this case, since we are dealing with the masters handles and not the workers.
added a commit
Nov 19, 2013
@avaitla the branch