New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Tornado change breaks gunicorn.workers.gtornado #771

Closed
bdarnell opened this Issue Jun 2, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@bdarnell

bdarnell commented Jun 2, 2014

The next release of Tornado (will be 4.0 when released, although the current master branch hasn't been updated to change all mentions of 3.3 to 4.0) makes some major changes to the HTTP internals and breaks gunicorn's monkey-patching of HTTPConnection.finish. Fortunately, there is now a cleaner way to do the tracking that gunicorn wants to do here, since the interface between HTTPServer and Application is more formally defined by the HTTPServerConnectionDelegate and HTTPMessageDelegate interfaces, so you should be able to wrap the Application (which implements/subclasses HTTPServerConnectionDelegate) and the HTTPMessageDelegate its start_request method returns.

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Jun 3, 2014

Collaborator

Thanks, @bdarnell. Since you're familiar with these changes, do you think you could write a patch?

Collaborator

tilgovi commented Jun 3, 2014

Thanks, @bdarnell. Since you're familiar with these changes, do you think you could write a patch?

@bdarnell

This comment has been minimized.

Show comment
Hide comment
@bdarnell

bdarnell Jun 3, 2014

I've never actually used gunicorn and it doesn't look like there is any unit test coverage of this module, so I'm probably not the best person to make this change.

bdarnell commented Jun 3, 2014

I've never actually used gunicorn and it doesn't look like there is any unit test coverage of this module, so I'm probably not the best person to make this change.

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jun 12, 2014

Owner

@bdarnell thanks! I will make sure the worker is working for the next release. Any idea when the 4.0 will be out?

Owner

benoitc commented Jun 12, 2014

@bdarnell thanks! I will make sure the worker is working for the next release. Any idea when the 4.0 will be out?

@benoitc benoitc added this to the R19.1 milestone Jun 12, 2014

@bdarnell

This comment has been minimized.

Show comment
Hide comment
@bdarnell

bdarnell Jun 12, 2014

I'm going to release a beta of 4.0 within a couple of weeks.

I'm going to release a beta of 4.0 within a couple of weeks.

@bdarnell

This comment has been minimized.

Show comment
Hide comment
@bdarnell

bdarnell Jul 16, 2014

I apologize for forgetting to ping this thread again, but Tornado 4.0 was just released today.

I apologize for forgetting to ping this thread again, but Tornado 4.0 was just released today.

@benoitc benoitc modified the milestones: R19.1, R19.2 Jul 26, 2014

@benoitc benoitc self-assigned this Jul 26, 2014

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jul 26, 2014

Owner

@bdarnell thanks, should be fixed with a release today, I'm working on it :)

Owner

benoitc commented Jul 26, 2014

@bdarnell thanks, should be fixed with a release today, I'm working on it :)

benoitc added a commit that referenced this issue Jul 26, 2014

@benoitc benoitc closed this in #826 Jul 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment