Upcoming Tornado change breaks gunicorn.workers.gtornado #771

Closed
bdarnell opened this Issue Jun 2, 2014 · 6 comments

Projects

None yet

3 participants

@bdarnell
bdarnell commented Jun 2, 2014

The next release of Tornado (will be 4.0 when released, although the current master branch hasn't been updated to change all mentions of 3.3 to 4.0) makes some major changes to the HTTP internals and breaks gunicorn's monkey-patching of HTTPConnection.finish. Fortunately, there is now a cleaner way to do the tracking that gunicorn wants to do here, since the interface between HTTPServer and Application is more formally defined by the HTTPServerConnectionDelegate and HTTPMessageDelegate interfaces, so you should be able to wrap the Application (which implements/subclasses HTTPServerConnectionDelegate) and the HTTPMessageDelegate its start_request method returns.

@tilgovi
Collaborator
tilgovi commented Jun 3, 2014

Thanks, @bdarnell. Since you're familiar with these changes, do you think you could write a patch?

@bdarnell
bdarnell commented Jun 3, 2014

I've never actually used gunicorn and it doesn't look like there is any unit test coverage of this module, so I'm probably not the best person to make this change.

@benoitc
Owner
benoitc commented Jun 12, 2014

@bdarnell thanks! I will make sure the worker is working for the next release. Any idea when the 4.0 will be out?

@benoitc benoitc added this to the R19.1 milestone Jun 12, 2014
@bdarnell

I'm going to release a beta of 4.0 within a couple of weeks.

@benoitc benoitc modified the milestone: R19.2, R19.1 Jun 28, 2014
@bdarnell bdarnell referenced this issue in tornadoweb/tornado Jul 16, 2014
Closed

tornado.httpserver.HTTPConnection is gone #1114

@bdarnell

I apologize for forgetting to ping this thread again, but Tornado 4.0 was just released today.

@benoitc benoitc modified the milestone: R19.1, R19.2 Jul 26, 2014
@benoitc benoitc self-assigned this Jul 26, 2014
@benoitc
Owner
benoitc commented Jul 26, 2014

@bdarnell thanks, should be fixed with a release today, I'm working on it :)

@benoitc benoitc added a commit that referenced this issue Jul 26, 2014
@benoitc support tornado 4.0
fix #771
9ec27c1
@benoitc benoitc closed this in #826 Jul 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment