New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch OSError as well as ValueError on race condition #1052

Merged
merged 2 commits into from Jun 22, 2015

Conversation

Projects
None yet
4 participants
@jaingaurav
Contributor

jaingaurav commented Jun 21, 2015

The fix for issue #863 was incomplete as both OSError or ValueError could be
raised by os.fstat(). Thus we need to catch both types of exceptions

Additionally fixed some PEP8 formatting issues.

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Jun 22, 2015

Collaborator

LGTM

Collaborator

tilgovi commented Jun 22, 2015

LGTM

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jun 22, 2015

Owner

bike-shedding spotted, but can you split it in 2 commit? One for the PEP8 fix and the other for the exception clause?

Owner

benoitc commented Jun 22, 2015

bike-shedding spotted, but can you split it in 2 commit? One for the PEP8 fix and the other for the exception clause?

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jun 22, 2015

Owner

otherwise the patch is OK for me.

Owner

benoitc commented Jun 22, 2015

otherwise the patch is OK for me.

jaingaurav added some commits Jun 21, 2015

Catch OSError as well as ValueError on race condition
The fix for issue #863 was incomplete as both OSError or ValueError could be
raised by os.fstat(). Thus we need to catch both types of exceptions
@jaingaurav

This comment has been minimized.

Show comment
Hide comment
@jaingaurav

jaingaurav Jun 22, 2015

Contributor

@benoitc done

Contributor

jaingaurav commented Jun 22, 2015

@benoitc done

berkerpeksag added a commit that referenced this pull request Jun 22, 2015

Merge pull request #1052 from jaingaurav/oserror
Catch OSError as well as ValueError on race condition

@berkerpeksag berkerpeksag merged commit d478968 into benoitc:master Jun 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jun 22, 2015

Collaborator

Thanks!

Collaborator

berkerpeksag commented Jun 22, 2015

Thanks!

@jaingaurav

This comment has been minimized.

Show comment
Hide comment
@jaingaurav

jaingaurav Jun 22, 2015

Contributor

Thanks for merging this in so promptly.

Contributor

jaingaurav commented Jun 22, 2015

Thanks for merging this in so promptly.

@jaingaurav jaingaurav deleted the jaingaurav:oserror branch Jun 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment