Catch OSError as well as ValueError on race condition #1052

Merged
merged 2 commits into from Jun 22, 2015

Projects

None yet

4 participants

@jaingaurav
Contributor

The fix for issue #863 was incomplete as both OSError or ValueError could be
raised by os.fstat(). Thus we need to catch both types of exceptions

Additionally fixed some PEP8 formatting issues.

@tilgovi
Collaborator
tilgovi commented Jun 22, 2015

LGTM

@benoitc
Owner
benoitc commented Jun 22, 2015

bike-shedding spotted, but can you split it in 2 commit? One for the PEP8 fix and the other for the exception clause?

@benoitc
Owner
benoitc commented Jun 22, 2015

otherwise the patch is OK for me.

jaingaurav added some commits Jun 21, 2015
@jaingaurav jaingaurav Catch OSError as well as ValueError on race condition
The fix for issue #863 was incomplete as both OSError or ValueError could be
raised by os.fstat(). Thus we need to catch both types of exceptions
09007c7
@jaingaurav jaingaurav PEP8 fixes eed65c6
@jaingaurav
Contributor

@benoitc done

@berkerpeksag berkerpeksag merged commit d478968 into benoitc:master Jun 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berkerpeksag
Collaborator

Thanks!

@jaingaurav
Contributor

Thanks for merging this in so promptly.

@jaingaurav jaingaurav deleted the unknown repository branch Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment