New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include request URL in error message. #1071

Merged
merged 1 commit into from Jul 8, 2015

Conversation

Projects
None yet
3 participants
@wosc
Contributor

wosc commented Jul 8, 2015

Fixes #1061.

I didn't write a test since there don't seem to be any similar tests yet,
and I'm not familiar enough with the test infrastructure.

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jul 8, 2015

Collaborator

LGTM. I couldn't find an easy way to test this. See also #791.

Collaborator

berkerpeksag commented Jul 8, 2015

LGTM. I couldn't find an easy way to test this. See also #791.

benoitc added a commit that referenced this pull request Jul 8, 2015

Merge pull request #1071 from wosc/1061-log-uri
Include request URL in error message.

@benoitc benoitc merged commit 27df133 into benoitc:master Jul 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wking added a commit to wking/gunicorn that referenced this pull request Nov 3, 2017

workers.base: Log 500 error message
This makes it a bit easier to debug than just logging the fact that
there was an exception.  Also restore logging in the URI-less case,
since that was broken in 79011d0 (Include request URL in error
message, 2015-07-08, #1071) but not restored in 1ccebab (prevent
crash when reporting an error, 2016-03-22, #1231).

wking added a commit to wking/gunicorn that referenced this pull request Nov 3, 2017

workers.base: Log 500 error message
This makes it a bit easier to debug than just logging the fact that
there was an exception.  Also restore logging in the URI-less case,
since that was broken in 79011d0 (Include request URL in error
message, 2015-07-08, #1071) but not restored in 1ccebab (prevent
crash when reporting an error, 2016-03-22, #1231).

wking added a commit to wking/gunicorn that referenced this pull request Nov 3, 2017

gunicorn: Use exc_info liberally
The argument is documented in [1], and we've been using it in some
cases since 410bcfa (Fix statsd logging to work on Python 3,
2015-04-20, #1010).  This commit goes through all of our log calls and
makes sure we're using it consistently.

For more examples of using exc_info instead of direct traceback calls,
see 0acfb55 (Let logging module handle traceback printing,
2016-02-05, #1201).  The traceback call I'm removing snuck in later
with f4842a5 (Log exception occurring during worker exit, 2016-05-04,
#1254).

I'm removing the "Error processing SSL request" debug messages,
because those will be handled by the subsequent handle_error call.
We've had them, for reasons that I'm not clear on, since 1198cc2
(handle ssl connections, 2012-12-14).

I've restored logging in the URI-less Worker.handle_error 500 case,
since that was broken in 79011d0 (Include request URL in error
message, 2015-07-08, #1071) but not restored in 1ccebab (prevent
crash when reporting an error, 2016-03-22, #1231).

[1]: https://docs.python.org/2/library/logging.html#logging.Logger.debug

wking added a commit to wking/gunicorn that referenced this pull request Nov 3, 2017

gunicorn: Use exc_info liberally
The argument is documented in [1], and we've been using it in some
cases since 410bcfa (Fix statsd logging to work on Python 3,
2015-04-20, #1010).  This commit goes through all of our log calls and
makes sure we're using it consistently.

For more examples of using exc_info instead of direct traceback calls,
see 0acfb55 (Let logging module handle traceback printing,
2016-02-05, #1201).  The traceback call I'm removing snuck in later
with f4842a5 (Log exception occurring during worker exit, 2016-05-04,
#1254).

I'm removing the "Error processing SSL request" debug messages,
because those will be handled by the subsequent handle_error call.
We've had them, for reasons that I'm not clear on, since 1198cc2
(handle ssl connections, 2012-12-14).

I've restored logging in the URI-less Worker.handle_error 500 case,
since that was broken in 79011d0 (Include request URL in error
message, 2015-07-08, #1071) but not restored in 1ccebab (prevent
crash when reporting an error, 2016-03-22, #1231).

Tests for the lines I've touched may be more trouble than they're
worth.  I've worked up one for a broken worker_exit hook to show what
they look like, but left the others untested for now.

[1]: https://docs.python.org/2/library/logging.html#logging.Logger.debug

wking added a commit to wking/gunicorn that referenced this pull request Nov 3, 2017

gunicorn: Use exc_info liberally
The argument is documented in [1], and we've been using it in some
cases since 410bcfa (Fix statsd logging to work on Python 3,
2015-04-20, #1010).  This commit goes through all of our log calls and
makes sure we're using it consistently.

For more examples of using exc_info instead of direct traceback calls,
see 0acfb55 (Let logging module handle traceback printing,
2016-02-05, #1201).  The traceback call I'm removing snuck in later
with f4842a5 (Log exception occurring during worker exit, 2016-05-04,
#1254).

I'm removing the "Error processing SSL request" debug messages,
because those will be handled by the subsequent handle_error call.
We've had them, for reasons that I'm not clear on, since 1198cc2
(handle ssl connections, 2012-12-14).

I've restored logging in the URI-less Worker.handle_error 500 case,
since that was broken in 79011d0 (Include request URL in error
message, 2015-07-08, #1071) but not restored in 1ccebab (prevent
crash when reporting an error, 2016-03-22, #1231).

Tests for the lines I've touched may be more trouble than they're
worth.  I've worked up one for a broken worker_exit hook to show what
they look like, but left the others untested for now.

[1]: https://docs.python.org/2/library/logging.html#logging.Logger.debug

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request #1071 from wosc/1061-log-uri
Include request URL in error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment