New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the --install option instead of sudo. #1072

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Projects
None yet
3 participants
@berkerpeksag
Collaborator

berkerpeksag commented Jul 8, 2015

No description provided.

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Jul 8, 2015

Collaborator

How reliably is the --user install bin going to be in the user's path?

Collaborator

tilgovi commented Jul 8, 2015

How reliably is the --user install bin going to be in the user's path?

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jul 8, 2015

Owner

I have no ideas on what is doing this command, so I will trust you about it :)

Owner

benoitc commented Jul 8, 2015

I have no ideas on what is doing this command, so I will trust you about it :)

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jul 8, 2015

Collaborator

How reliably is the --user install bin going to be in the user's path?

No idea, but it's better than sudo anyway :)

Collaborator

berkerpeksag commented Jul 8, 2015

How reliably is the --user install bin going to be in the user's path?

No idea, but it's better than sudo anyway :)

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jul 8, 2015

Collaborator

Actually, we can just remove virtualenv lines.

$ pip install gunicorn
$ cat myapp.py
   def app(environ, start_response):
       data = b"Hello, World!\n"
       start_response("200 OK", [
           ("Content-Type", "text/plain"),
           ("Content-Length", str(len(data)))
       ])
       return iter([data])
$ gunicorn -w 4 myapp:app

looks simpler to me.

Collaborator

berkerpeksag commented Jul 8, 2015

Actually, we can just remove virtualenv lines.

$ pip install gunicorn
$ cat myapp.py
   def app(environ, start_response):
       data = b"Hello, World!\n"
       start_response("200 OK", [
           ("Content-Type", "text/plain"),
           ("Content-Length", str(len(data)))
       ])
       return iter([data])
$ gunicorn -w 4 myapp:app

looks simpler to me.

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jul 8, 2015

Owner

+1

On Wed, Jul 8, 2015 at 7:51 PM Berker Peksag notifications@github.com
wrote:

Actually, we can just remove virtualenv lines.

$ pip install gunicorn
$ cat myapp.py
def app(environ, start_response):
data = b"Hello, World!\n"
start_response("200 OK", [
("Content-Type", "text/plain"),
("Content-Length", str(len(data)))
])
return iter([data])
$ gunicorn -w 4 myapp:app

looks simpler to me.


Reply to this email directly or view it on GitHub
#1072 (comment).

Owner

benoitc commented Jul 8, 2015

+1

On Wed, Jul 8, 2015 at 7:51 PM Berker Peksag notifications@github.com
wrote:

Actually, we can just remove virtualenv lines.

$ pip install gunicorn
$ cat myapp.py
def app(environ, start_response):
data = b"Hello, World!\n"
start_response("200 OK", [
("Content-Type", "text/plain"),
("Content-Length", str(len(data)))
])
return iter([data])
$ gunicorn -w 4 myapp:app

looks simpler to me.


Reply to this email directly or view it on GitHub
#1072 (comment).

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Jul 8, 2015

Collaborator

Sounds good to me. Virtualenv is the user's choice. We can add a note about virtualenv generally, pointing to a tutorial, if we want to.

Collaborator

tilgovi commented Jul 8, 2015

Sounds good to me. Virtualenv is the user's choice. We can add a note about virtualenv generally, pointing to a tutorial, if we want to.

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jul 15, 2015

Owner

@berkerpeksag so let's go with out sudo then :)

Owner

benoitc commented Jul 15, 2015

@berkerpeksag so let's go with out sudo then :)

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Dec 23, 2015

Owner

bump.

Owner

benoitc commented Dec 23, 2015

bump.

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Dec 26, 2015

Collaborator

👍 to removing virtualenv from the instructions.

Collaborator

tilgovi commented Dec 26, 2015

👍 to removing virtualenv from the instructions.

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Dec 27, 2015

Collaborator

I will update this today, thanks for the reviews!

Collaborator

berkerpeksag commented Dec 27, 2015

I will update this today, thanks for the reviews!

@berkerpeksag berkerpeksag merged commit 3ccdafb into benoitc:master Jan 5, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@berkerpeksag berkerpeksag deleted the berkerpeksag:pip-user branch Jan 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment