New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't close the unix socket when the worker exit #1088

Merged
merged 1 commit into from Jul 23, 2015

Conversation

Projects
None yet
2 participants
@benoitc
Owner

benoitc commented Jul 22, 2015

When the worker was exiting, eventlet is closing the listening socket in th
worker. Since the socket instances are shared, this was also removing the unix
socket on close. This change make sure that the socket can only be closed by
its parent (where the socket have been bound).

While I'm here, also make sure we don't use any blocking function in eventlet
while switching).

fix #965

don't close the unix socket when the worker exit
When the worker was exiting, eventlet is closing the listening socket in th
worker. Since the socket instances are shared, this was also removing the unix
socket on close. This change make sure that the socket can only be closed by
its parent (where the socket have been bound).

While I'm here, also make sure we don't use any blocking function in eventlet
while switching).

fix #965
@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Jul 22, 2015

Collaborator

That's a nice way to fix it.

Collaborator

tilgovi commented Jul 22, 2015

That's a nice way to fix it.

benoitc added a commit that referenced this pull request Jul 23, 2015

Merge pull request #1088 from benoitc/fix/905
don't close the unix socket when the worker exit

@benoitc benoitc merged commit 89562c7 into master Jul 23, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jul 23, 2015

Owner

merged. Thanks for the review!

Owner

benoitc commented Jul 23, 2015

merged. Thanks for the review!

@tilgovi tilgovi deleted the fix/905 branch Jul 23, 2015

martijnvermaat added a commit to varda/ansible-role-varda that referenced this pull request Nov 12, 2015

Temporarily disable Gunicorn worker autoreload
This is a temporary measure to workaround [1]. When the fix [2] is in
a Gunicorn release, we should update our Gunicorn to that release.

[1] benoitc/gunicorn#965
[2] benoitc/gunicorn#1088

martijnvermaat added a commit to varda/ansible-role-varda that referenced this pull request Nov 12, 2015

Update Gunicorn and restore worker autoreload
As per a430561 we upgrade Gunicorn to the latest release containing a
fix [1] for [2].

[1] benoitc/gunicorn#1088
[2] benoitc/gunicorn#965

martijnvermaat added a commit to varda/ansible-role-varda that referenced this pull request Dec 4, 2015

Update Gunicorn and restore worker autoreload
As per a430561 we upgrade Gunicorn to the latest release containing a
fix [1] for [2].

[1] benoitc/gunicorn#1088
[2] benoitc/gunicorn#965

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request #1088 from benoitc/fix/905
don't close the unix socket when the worker exit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment