New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support for gaiohttp worker #1105

Merged
merged 1 commit into from Aug 25, 2015

Conversation

Projects
None yet
3 participants
@tumb1er
Contributor

tumb1er commented Aug 25, 2015

Initialize and pass SSLContext to asyncio.loop.create_server to enable ssl support.

Once again - see #1092

SSL support for gaiohttp worker
Initialize and pass `SSLContext` to `asyncio.loop.create_server` to enable ssl support.
@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Aug 25, 2015

Owner

👍

Owner

benoitc commented Aug 25, 2015

👍

benoitc added a commit that referenced this pull request Aug 25, 2015

Merge pull request #1105 from tumb1er/ssl_gaiohttp
SSL support for gaiohttp worker

@benoitc benoitc merged commit 209a605 into benoitc:master Aug 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Aug 25, 2015

Owner

thanks!

Owner

benoitc commented Aug 25, 2015

thanks!

@tumb1er tumb1er deleted the tumb1er:ssl_gaiohttp branch Aug 25, 2015

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Aug 25, 2015

Collaborator

If we have a _create_socket method to make subclassing and customization easier, shouldn't we make it a public method(e.g. without a _ prefix and document its intent in the docstring)?

Collaborator

berkerpeksag commented Aug 25, 2015

If we have a _create_socket method to make subclassing and customization easier, shouldn't we make it a public method(e.g. without a _ prefix and document its intent in the docstring)?

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request #1105 from tumb1er/ssl_gaiohttp
SSL support for gaiohttp worker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment