SSL support for gaiohttp worker #1105

Merged
merged 1 commit into from Aug 25, 2015

Projects

None yet

3 participants

@tumb1er
Contributor
tumb1er commented Aug 25, 2015

Initialize and pass SSLContext to asyncio.loop.create_server to enable ssl support.

Once again - see #1092

@tumb1er tumb1er SSL support for gaiohttp worker
Initialize and pass `SSLContext` to `asyncio.loop.create_server` to enable ssl support.
21c7e10
@benoitc
Owner
benoitc commented Aug 25, 2015

👍

@benoitc benoitc merged commit 209a605 into benoitc:master Aug 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benoitc
Owner
benoitc commented Aug 25, 2015

thanks!

@tumb1er tumb1er deleted the tumb1er:ssl_gaiohttp branch Aug 25, 2015
@berkerpeksag
Collaborator

If we have a _create_socket method to make subclassing and customization easier, shouldn't we make it a public method(e.g. without a _ prefix and document its intent in the docstring)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment