Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
remove checking timeouts while graceful stopping tornado worker #1106
Hello, @benoitc. The first 2 commits were about 2 years ago, and you should have merged it.
Actually, there would be anther issue when I using Supervisor to manage Gunicorn process.
The default graceful_timeout of Gunicorn is 30 seconds. So when I restarting Gunicorn master process, it will wait its workers to exit up to 30 seconds.
I have changed the graceful_timeout to 8 seconds in my project, but I think there could be a mechanism to kill the workers once the master got killed.
I should probably have but I am really busy these days launching a new business.
About the patches can you split the prs? the possible infinite loop should be done in another PR.
About the timeout can't you tell to supervisor to send a SIGTERM instead of a SIGQUIT? There is indeed already a mechanism to exit immediately Gunicorn. If it doesn't work with the tornado worker, let me know.