New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accesslog params #1132

Merged
merged 1 commit into from Oct 22, 2015

Conversation

Projects
None yet
3 participants
@bungoume
Contributor

bungoume commented Oct 21, 2015

I would like to add accesslog params like Apache.
If you do not mind, please merge.

ref: http://httpd.apache.org/docs/current/mod/mod_log_config.html

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Oct 21, 2015

Owner

i like the idea, however the tests don't pass right now. Seems PATH_INFO doesn't exist during the tests. Can you fix it ?

Owner

benoitc commented Oct 21, 2015

i like the idea, however the tests don't pass right now. Seems PATH_INFO doesn't exist during the tests. Can you fix it ?

@bungoume

This comment has been minimized.

Show comment
Hide comment
@bungoume

bungoume Oct 21, 2015

Contributor

Oh sorry, I'll fix it.

Contributor

bungoume commented Oct 21, 2015

Oh sorry, I'll fix it.

Add accesslog params
Fix KeyError

Update access logger tests

Update settings.rst docs
@bungoume

This comment has been minimized.

Show comment
Hide comment
@bungoume

bungoume Oct 21, 2015

Contributor

Fixed test. Could you review?

Contributor

bungoume commented Oct 21, 2015

Fixed test. Could you review?

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Oct 22, 2015

Collaborator

LGTM

Collaborator

tilgovi commented Oct 22, 2015

LGTM

tilgovi added a commit that referenced this pull request Oct 22, 2015

@tilgovi tilgovi merged commit 50a40b5 into benoitc:master Oct 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment