New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation of graceful_timeout #1137

Merged
merged 1 commit into from Nov 2, 2015

Conversation

Projects
None yet
3 participants
@abesto
Contributor

abesto commented Oct 30, 2015

No description provided.

Show outdated Hide outdated docs/source/settings.rst
Generally set to thirty seconds. How max time worker can handle
request after got restart signal. If the time is up worker will
be force killed.
Generally set to thirty seconds. After reciving a restart signal,

This comment has been minimized.

@berkerpeksag

berkerpeksag Oct 30, 2015

Collaborator

typo: reciving -> receiving

@berkerpeksag

berkerpeksag Oct 30, 2015

Collaborator

typo: reciving -> receiving

This comment has been minimized.

@abesto

abesto Oct 30, 2015

Contributor

Meh. Thanks!

@abesto

abesto Oct 30, 2015

Contributor

Meh. Thanks!

Show outdated Hide outdated docs/source/settings.rst
Generally set to thirty seconds. How max time worker can handle
request after got restart signal. If the time is up worker will
be force killed.
Generally set to thirty seconds. After receiving a restart signal,

This comment has been minimized.

@tilgovi

tilgovi Oct 30, 2015

Collaborator

I would remove this first sentence. It repeats information that is already above, in the default value.

@tilgovi

tilgovi Oct 30, 2015

Collaborator

I would remove this first sentence. It repeats information that is already above, in the default value.

This comment has been minimized.

@abesto

abesto Nov 2, 2015

Contributor

Good point!

@abesto

abesto Nov 2, 2015

Contributor

Good point!

berkerpeksag added a commit that referenced this pull request Nov 2, 2015

Merge pull request #1137 from abesto/doc/graceful_timeout
Clarify documentation of graceful_timeout

@berkerpeksag berkerpeksag merged commit eb29a44 into benoitc:master Nov 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Nov 2, 2015

Collaborator

Thanks!

Collaborator

berkerpeksag commented Nov 2, 2015

Thanks!

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request #1137 from abesto/doc/graceful_timeout
Clarify documentation of graceful_timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment