Clarify documentation of graceful_timeout #1137

Merged
merged 1 commit into from Nov 2, 2015

Projects

None yet

3 participants

@abesto
Contributor
abesto commented Oct 30, 2015

No description provided.

@berkerpeksag berkerpeksag and 1 other commented on an outdated diff Oct 30, 2015
docs/source/settings.rst
@@ -185,9 +185,10 @@ graceful_timeout
Timeout for graceful workers restart.
-Generally set to thirty seconds. How max time worker can handle
-request after got restart signal. If the time is up worker will
-be force killed.
+Generally set to thirty seconds. After reciving a restart signal,
@berkerpeksag
berkerpeksag Oct 30, 2015 Collaborator

typo: reciving -> receiving

@abesto
abesto Oct 30, 2015 Contributor

Meh. Thanks!

@tilgovi tilgovi and 1 other commented on an outdated diff Oct 30, 2015
docs/source/settings.rst
@@ -185,9 +185,10 @@ graceful_timeout
Timeout for graceful workers restart.
-Generally set to thirty seconds. How max time worker can handle
-request after got restart signal. If the time is up worker will
-be force killed.
+Generally set to thirty seconds. After receiving a restart signal,
@tilgovi
tilgovi Oct 30, 2015 Collaborator

I would remove this first sentence. It repeats information that is already above, in the default value.

@abesto
abesto Nov 2, 2015 Contributor

Good point!

@berkerpeksag berkerpeksag merged commit eb29a44 into benoitc:master Nov 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berkerpeksag
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment